Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2247923004: Add IDL parsing of FeaturePolicy extended attribute (Closed)

Created:
4 years, 4 months ago by iclelland
Modified:
4 years, 4 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add IDL parsing of FeaturePolicy extended attribute This is an interim step to handle FeaturePolicy-enabled features, before the three conditional feature flags (RuntimeEnabled, OriginTrialEnabled and FeaturePolicy) are eventually combined into a common 'Feature' attribute. BUG=638240 Committed: https://crrev.com/60deeff69759a9fe496984280386a8d1213fd797 Cr-Commit-Position: refs/heads/master@{#412524}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Alphabetize defaults list in make_runtime_features.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M third_party/WebKit/Source/bindings/IDLExtendedAttributes.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_utilities.py View 2 chunks +16 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/make_runtime_features.py View 1 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
iclelland
+r Yuki -- can you PTAL? Thanks!
4 years, 4 months ago (2016-08-16 15:08:52 UTC) #5
haraken
LGTM > before the three conditional feature flags (RuntimeEnabled, OriginTrialEnabled and > FeaturePolicy) are eventually ...
4 years, 4 months ago (2016-08-17 01:18:44 UTC) #9
Yuki
lgtm
4 years, 4 months ago (2016-08-17 03:16:46 UTC) #10
iclelland
> Yeah, I want to make this happen. Do you have any timeline for the ...
4 years, 4 months ago (2016-08-17 13:25:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2247923004/20001
4 years, 4 months ago (2016-08-17 13:26:39 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-17 14:44:12 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 14:45:28 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/60deeff69759a9fe496984280386a8d1213fd797
Cr-Commit-Position: refs/heads/master@{#412524}

Powered by Google App Engine
This is Rietveld 408576698