Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2247913002:
clang: Include sancov binary in prebuilt archive. (Closed)
|
Created:
4 years, 4 months ago by Oliver Chang Modified:
4 years, 4 months ago CC:
chromium-reviews, inferno, aizatsky Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionclang: Include sancov binary in prebuilt archive.
This tool is used for processing sanitizer coverage data
dumped by Chrome. We need this to be included in archives
built for CF.
BUG=636168
Committed: https://crrev.com/30e298a68779beb7b16ea49b156b37b8ffcc9a04
Cr-Commit-Position: refs/heads/master@{#412056}
Patch Set 1 #
Messages
Total messages: 15 (7 generated)
Description was changed from ========== clang: Include sancov binary in prebuilt archive. BUG=636168 ========== to ========== clang: Include sancov binary in prebuilt archive. BUG=636168 ==========
ochang@chromium.org changed reviewers: + hans@chromium.org, thakis@chromium.org
ptal
Please add a motivation to the change description. What's this used for? What's the impact on the package size? We're trying to be mindful of the clang package that we push to developers. It's currently 33MB on Linux. How much would adding sancov (which is 14MB on my machine) grow it?
Description was changed from ========== clang: Include sancov binary in prebuilt archive. BUG=636168 ========== to ========== clang: Include sancov binary in prebuilt archive. This is needed to process sanitizer coverage information by ClusterFuzz. BUG=636168 ==========
Description was changed from ========== clang: Include sancov binary in prebuilt archive. This is needed to process sanitizer coverage information by ClusterFuzz. BUG=636168 ========== to ========== clang: Include sancov binary in prebuilt archive. This tool is used for processing sanitizer coverage data dumped by Chrome. We need this to be included in archives built for CF. BUG=636168 ==========
On 2016/08/15 20:29:51, hans wrote: > Please add a motivation to the change description. What's this used for? > > What's the impact on the package size? We're trying to be mindful of the clang > package that we push to developers. It's currently 33MB on Linux. How much would > adding sancov (which is 14MB on my machine) grow it? I added the motivation to the description. We need sancov to be included with Chrome archives built for CF, similar to how it's done with llvm-symbolizer right now. As for the size increase, I ran package.py locally on my machine and compared it to the corresponding archive on gs://chromium-browser-clang: 34226416 bytes -> 35921454 bytes, so about a 1.7MB increase.
On 2016/08/15 20:41:44, Oliver Chang wrote: > 34226416 bytes -> 35921454 bytes, so about a 1.7MB increase. That's not too bad. Thanks for running the numbers! lgtm
On 2016/08/15 20:47:39, hans wrote: > On 2016/08/15 20:41:44, Oliver Chang wrote: > > 34226416 bytes -> 35921454 bytes, so about a 1.7MB increase. > > That's not too bad. Thanks for running the numbers! > > lgtm great, thanks for the approval :)
The CQ bit was checked by ochang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== clang: Include sancov binary in prebuilt archive. This tool is used for processing sanitizer coverage data dumped by Chrome. We need this to be included in archives built for CF. BUG=636168 ========== to ========== clang: Include sancov binary in prebuilt archive. This tool is used for processing sanitizer coverage data dumped by Chrome. We need this to be included in archives built for CF. BUG=636168 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== clang: Include sancov binary in prebuilt archive. This tool is used for processing sanitizer coverage data dumped by Chrome. We need this to be included in archives built for CF. BUG=636168 ========== to ========== clang: Include sancov binary in prebuilt archive. This tool is used for processing sanitizer coverage data dumped by Chrome. We need this to be included in archives built for CF. BUG=636168 Committed: https://crrev.com/30e298a68779beb7b16ea49b156b37b8ffcc9a04 Cr-Commit-Position: refs/heads/master@{#412056} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/30e298a68779beb7b16ea49b156b37b8ffcc9a04 Cr-Commit-Position: refs/heads/master@{#412056} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
