Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1445)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 2247873002: Android: Don't hold frame lock during readback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2785
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index 29121a6e41f07eb62faa8fb118d593939774ab42..e08b961c4f1e9c5881a337f43c35b0093bcb4237 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -910,9 +910,6 @@ void RenderWidgetHostViewAndroid::CopyFromCompositingSurface(
if (!src_subrect_in_pixel.IsEmpty())
request->set_area(src_subrect_in_pixel);
- // Make sure the current frame doesn't get deleted until we fulfill the
- // request.
- LockCompositingSurface();
surface_factory_->RequestCopyOfSurface(surface_id_, std::move(request));
}
@@ -1919,8 +1916,6 @@ void RenderWidgetHostViewAndroid::PrepareTextureCopyOutputResult(
TRACE_EVENT0("cc",
"RenderWidgetHostViewAndroid::PrepareTextureCopyOutputResult");
readback_layer->RemoveFromParent();
- if (rwhva)
- rwhva->UnlockCompositingSurface();
if (!result->HasTexture() || result->IsEmpty() || result->size().IsEmpty())
return;
cc::TextureMailbox texture_mailbox;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698