Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2247793002: Update to DEPS to `linter 0.1.24`. (Closed)

Created:
4 years, 4 months ago by pquitslund
Modified:
4 years, 4 months ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update to DEPS to `linter 0.1.24`. Picks up: * Internal updates to keep up with changes in the analyzer package. * Updated `close_sinks` to respect calls to `destroy` (#282). * Fixed `only_throw_errors` to report on the expression not node. BUG= R=paulberry@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/e5029df4f2a045e244ee97f9457dd881b6964ea6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
pquitslund
4 years, 4 months ago (2016-08-15 17:00:02 UTC) #2
scheglov
LGTM
4 years, 4 months ago (2016-08-15 17:00:30 UTC) #3
Paul Berry
lgtm
4 years, 4 months ago (2016-08-15 17:44:41 UTC) #4
pquitslund
4 years, 4 months ago (2016-08-15 17:46:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e5029df4f2a045e244ee97f9457dd881b6964ea6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698