Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2247783003: Avoid setting timers from SVGImage::resetAnimation() (Closed)

Created:
4 years, 4 months ago by fs
Modified:
4 years, 4 months ago
Reviewers:
pdr.
CC:
blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid setting timers from SVGImage::resetAnimation() When resetting the timeline to t=0, we may up generating syncbase notification, which sets up a timer (to update any possibly dependent intervals.) Since resetAnimation() is what's called when the (SVG)Image no longer has any clients, we should try to make sure it is indeed idle after that happens. This avoids trying to update animation state while the image is otherwise dead, leaving "reactivation" to the time it is next painted. BUG=627418 Committed: https://crrev.com/12c039d9866df4bae5c2b1a398b04816701233b3 Cr-Commit-Position: refs/heads/master@{#412798}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M third_party/WebKit/Source/core/svg/graphics/SVGImage.h View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp View 4 chunks +23 lines, -1 line 0 comments Download

Messages

Total messages: 21 (9 generated)
fs
No test here because it involve racing against the GC-heuristics (takes quite a while to ...
4 years, 4 months ago (2016-08-16 15:23:29 UTC) #6
pdr.
This isn't crashing at all for me locally. Did you use ASAN/MSAN/PARMESAN or does it ...
4 years, 4 months ago (2016-08-17 03:20:30 UTC) #7
fs
On 2016/08/17 at 03:20:30, pdr wrote: > This isn't crashing at all for me locally. ...
4 years, 4 months ago (2016-08-17 09:15:05 UTC) #8
fs
On 2016/08/17 at 09:15:05, fs wrote: > On 2016/08/17 at 03:20:30, pdr wrote: > > ...
4 years, 4 months ago (2016-08-17 12:57:04 UTC) #9
pdr.
On 2016/08/17 at 12:57:04, fs wrote: > On 2016/08/17 at 09:15:05, fs wrote: > > ...
4 years, 4 months ago (2016-08-17 18:01:28 UTC) #10
fs
On 2016/08/17 at 18:01:28, pdr wrote: > On 2016/08/17 at 12:57:04, fs wrote: > > ...
4 years, 4 months ago (2016-08-17 18:14:23 UTC) #11
pdr.
On 2016/08/17 at 18:14:23, fs wrote: > On 2016/08/17 at 18:01:28, pdr wrote: > > ...
4 years, 4 months ago (2016-08-17 18:15:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2247783003/1
4 years, 4 months ago (2016-08-18 07:43:24 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/124875)
4 years, 4 months ago (2016-08-18 08:55:57 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2247783003/1
4 years, 4 months ago (2016-08-18 10:29:00 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 12:04:58 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 12:09:26 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12c039d9866df4bae5c2b1a398b04816701233b3
Cr-Commit-Position: refs/heads/master@{#412798}

Powered by Google App Engine
This is Rietveld 408576698