Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2247773002: [Cronet] Fix testDestroyUploadDataStreamAdapterOnSucceededCallback flake. (Closed)

Created:
4 years, 4 months ago by xunjieli
Modified:
4 years, 4 months ago
Reviewers:
kapishnikov
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Fix testDestroyUploadDataStreamAdapterOnSucceededCallback flake. This CL makes testDestroyUploadDataStreamAdapterOnSucceededCallback to wait until the request finishes, so tearDown() can safely shut down the CronetEngine. BUG=635618 Committed: https://crrev.com/a3374c6c22d11e179773fbf1a89673f7e0a362e1 Cr-Commit-Position: refs/heads/master@{#411999}

Patch Set 1 : self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
xunjieli
4 years, 4 months ago (2016-08-15 16:50:00 UTC) #9
kapishnikov
Good catch! LGTM
4 years, 4 months ago (2016-08-15 16:55:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2247773002/20001
4 years, 4 months ago (2016-08-15 17:51:00 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 4 months ago (2016-08-15 18:39:36 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 18:46:01 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3374c6c22d11e179773fbf1a89673f7e0a362e1
Cr-Commit-Position: refs/heads/master@{#411999}

Powered by Google App Engine
This is Rietveld 408576698