Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2247733005: Correct and GC unrecognized flags from our tests. (Closed)

Created:
4 years, 4 months ago by Florian Schneider
Modified:
4 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Correct and GC unrecognized flags from our tests. Fix some misspelled flags. Remove some non-existent flags. Fix --short_socket_read and --short_socket_write flags used in IO tests. Running with --ignore-unrecognized-flags is still on because some flags are only visible in DEBUG mode. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/021ebb203315509d16ccddc24e78df8473b3a3f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -41 lines) Patch
M runtime/bin/main.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M runtime/bin/socket.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M runtime/observatory/tests/service/capture_stdio_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/vm_restart_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/hash_map2_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/corelib/hash_map_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/isolate/enum_const_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/isolate/message_enum_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/await_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/enum_duplicate_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/enum_index_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/enum_mirror_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/enum_private_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/enum_syntax_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/enum_test.dart View 2 chunks +1 line, -3 lines 0 comments Download
M tests/language/function_field_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/vm/regress_16873_test.dart View 1 chunk +1 line, -1 line 0 comments Download
D tests/standalone/no_support_coverage_test.dart View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
4 years, 4 months ago (2016-08-16 00:50:18 UTC) #2
siva
lgtm
4 years, 4 months ago (2016-08-16 00:55:37 UTC) #3
Florian Schneider
4 years, 4 months ago (2016-08-16 01:28:17 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
021ebb203315509d16ccddc24e78df8473b3a3f7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698