Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2247663003: Add packages for the http launch test (fix bot redness) (Closed)

Created:
4 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 4 months ago
Reviewers:
eernst
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add packages for the http launch test BUG= Committed: https://github.com/dart-lang/sdk/commit/42208539a3da640b0da285db0715dde261b906a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
A + tests/compiler/dart2js/quarantined/http_launch_data/packages/simple/simple.dart View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Siggi Cherem (dart-lang)
TBR
4 years, 4 months ago (2016-08-15 15:37:23 UTC) #2
Siggi Cherem (dart-lang)
Committed patchset #1 (id:1) manually as 42208539a3da640b0da285db0715dde261b906a7 (presubmit successful).
4 years, 4 months ago (2016-08-15 15:37:30 UTC) #4
eernst
4 years, 4 months ago (2016-08-16 07:18:42 UTC) #5
Message was sent while issue was closed.
On 2016/08/15 15:37:30, Siggi Cherem (dart-lang) wrote:
> Committed patchset #1 (id:1) manually as
> 42208539a3da640b0da285db0715dde261b906a7 (presubmit successful).

Funny, Rietveld is convinced that it is a copy operation. But it LGTM.

Powered by Google App Engine
This is Rietveld 408576698