Keep "Add" button in "Add to Homescreen" dialog disabled till launcher icon is fetched

Keep "Add" button in "Add to Homescreen" dialog disabled till launcher icon is fetched

This CL fixes a bug where the "Add" button would be enabled if the user modifies
the dialog text prior to AddToHomescreenDialogHelper#onIconAvailable() being
called.

BUG=637630
Committed: https://crrev.com/2d932dfbfe8c3c8e3252c98d04509a3bd639a216
Cr-Commit-Position: refs/heads/master@{#412066}

[pkotwicz, 2016-08-15 03:02:24]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2016-08-15 03:02:31]

Patchset #1 (id:20001) has been deleted

[pkotwicz, 2016-08-15 03:06:11]

Patchset #1 (id:40001) has been deleted

[pkotwicz, 2016-08-15 03:10:07]

pkotwicz@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[pkotwicz, 2016-08-15 03:10:08]

Dan can you please take a look? I will add tests in a follow up CL. (I am making
changes which will make AddToHomescreenDialog more easily testable.)

The disabling logic when the field in the dialog is empty was added in
https://chrome-internal-review.googlesource.com/#/c/44402/

[pkotwicz, 2016-08-15 03:19:58]

Patchset #1 (id:60001) has been deleted

[gone, 2016-08-15 20:45:31]

lgtm

[pkotwicz, 2016-08-15 21:16:40]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2016-08-15 21:16:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 22:03:29]

Committed patchset #1 (id:80001)

[commit-bot: I haz the power, 2016-08-15 22:09:14]

Description was changed from

==========
Keep "Add" button in "Add to Homescreen" dialog disabled till launcher icon is
fetched

This CL fixes a bug where the "Add" button would be enabled if the user modifies
the dialog text prior to AddToHomescreenDialogHelper#onIconAvailable() being
called.

BUG=637630
==========

to

==========
Keep "Add" button in "Add to Homescreen" dialog disabled till launcher icon is
fetched

This CL fixes a bug where the "Add" button would be enabled if the user modifies
the dialog text prior to AddToHomescreenDialogHelper#onIconAvailable() being
called.

BUG=637630

Committed: https://crrev.com/2d932dfbfe8c3c8e3252c98d04509a3bd639a216
Cr-Commit-Position: refs/heads/master@{#412066}
==========

[commit-bot: I haz the power, 2016-08-15 22:09:15]

Patchset 1 (id:??) landed as
https://crrev.com/2d932dfbfe8c3c8e3252c98d04509a3bd639a216
Cr-Commit-Position: refs/heads/master@{#412066}