base/compiler_specific.h - Issue 224763005: win: Now that we're on msvs2013, spell final 'final' not 'sealed'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/compiler_specific.h

Issue 224763005: win: Now that we're on msvs2013, spell final 'final' not 'sealed'. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/compiler_specific.h

diff --git a/base/compiler_specific.h b/base/compiler_specific.h

index 16837dff479fcbca7b2a3109d9ef473bc78565df..79984b807b76136fd0c10e6e75226f2f52fc8907 100644

--- a/base/compiler_specific.h

+++ b/base/compiler_specific.h

@@ -154,11 +154,8 @@

// Use like:

// virtual void foo() FINAL;

// class B FINAL : public A {};

-#if defined(__clang__)

+#if defined(__clang__) || defined(COMPILER_MSVC)

#define FINAL final

-#elif defined(COMPILER_MSVC)

-// TODO(jered): Change this to "final" when chromium no longer uses MSVC 2010.

-#define FINAL sealed

#elif defined(COMPILER_GCC) && __cplusplus >= 201103 && \

scottmg 2014/04/04 00:30:04 guess you could merge all this too, but maybe it's

(__GNUC__ * 10000 + __GNUC_MINOR__ * 100) >= 40700

// GCC 4.7 supports explicit virtual overrides when C++11 support is enabled.

« no previous file with comments | « no previous file | no next file » | no next file with comments »