Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 224763003: Revert 261566 "device/bluetooth: Rename device::bluetooth_utils:..." (Closed)

Created:
6 years, 8 months ago by ncarter (slow)
Modified:
6 years, 8 months ago
Reviewers:
armansito
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 261566 "device/bluetooth: Rename device::bluetooth_utils:..." [ Reason for revert: broke asan compile http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Builder/builds/1676 ] > device/bluetooth: Rename device::bluetooth_utils::UUID to device::BluetoothUUID > > Moved bluetooth_utils::UUID into its own file called bluetooth_uuid.h/cc as > class BluetoothUUID. This effectively removes the usage of > bluetooth_utils::CanonicalUuid > > BUG=358874 > TEST=device_unittests, browser_tests > > Review URL: https://codereview.chromium.org/220323004 TBR=armansito@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261570

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -464 lines) Patch
M trunk/src/chrome/browser/extensions/api/bluetooth/bluetooth_api.h View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/bluetooth/bluetooth_api.cc View 6 chunks +11 lines, -10 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/bluetooth/bluetooth_api_utils.cc View 1 chunk +1 line, -6 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/bluetooth/bluetooth_apitest.cc View 4 chunks +5 lines, -9 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/bluetooth/bluetooth_event_router.h View 5 chunks +6 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/bluetooth/bluetooth_event_router.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/bluetooth/bluetooth_event_router_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M trunk/src/chrome/common/extensions/api/bluetooth/bluetooth_manifest_permission.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M trunk/src/chrome/test/data/extensions/api_test/bluetooth/on_connection/runtest.js View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/device/bluetooth/bluetooth.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_chromeos_unittest.cc View 9 chunks +17 lines, -21 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_device.h View 4 chunks +8 lines, -3 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_device.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_device_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/device/bluetooth/bluetooth_device_chromeos.cc View 5 chunks +6 lines, -14 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_device_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/device/bluetooth/bluetooth_device_mac.mm View 1 chunk +2 lines, -3 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_device_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_device_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_device_win_unittest.cc View 6 chunks +4 lines, -10 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_gatt_characteristic.h View 3 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_gatt_characteristic.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/device/bluetooth/bluetooth_gatt_descriptor.h View 9 chunks +10 lines, -10 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_gatt_descriptor.cc View 2 chunks +15 lines, -13 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_gatt_service.h View 3 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_gatt_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/device/bluetooth/bluetooth_profile.h View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_profile.cc View 2 chunks +3 lines, -1 line 0 comments Download
M trunk/src/device/bluetooth/bluetooth_profile_chromeos.h View 4 chunks +3 lines, -4 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_profile_chromeos.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_profile_chromeos_unittest.cc View 4 chunks +2 lines, -4 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_profile_mac.h View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_profile_mac.mm View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_profile_win.h View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_profile_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/device/bluetooth/bluetooth_service_record.h View 3 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_service_record_mac.mm View 1 chunk +1 line, -3 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_service_record_win.cc View 5 chunks +9 lines, -10 lines 0 comments Download
M trunk/src/device/bluetooth/bluetooth_service_record_win_unittest.cc View 5 chunks +5 lines, -6 lines 0 comments Download
A + trunk/src/device/bluetooth/bluetooth_utils.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/device/bluetooth/bluetooth_utils.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/device/bluetooth/bluetooth_utils_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/src/device/bluetooth/bluetooth_uuid.h View 1 chunk +0 lines, -94 lines 0 comments Download
D trunk/src/device/bluetooth/bluetooth_uuid.cc View 1 chunk +0 lines, -101 lines 0 comments Download
D trunk/src/device/bluetooth/bluetooth_uuid_unittest.cc View 1 chunk +0 lines, -76 lines 0 comments Download
M trunk/src/device/bluetooth/test/mock_bluetooth_device.h View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/device/device_tests.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ncarter (slow)
6 years, 8 months ago (2014-04-03 23:23:37 UTC) #1
ncarter (slow)
Committed patchset #1 manually as r261570 (tree was closed).
6 years, 8 months ago (2014-04-03 23:25:22 UTC) #2
armansito
6 years, 8 months ago (2014-04-03 23:26:40 UTC) #3
Message was sent while issue was closed.
On 2014/04/03 23:23:37, ncarter wrote:

lgtm. It just passed the CQ and the Mac bots were fine. I don't know why this
builder isn't part of the cq

Powered by Google App Engine
This is Rietveld 408576698