Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.h

Issue 2247543003: Tweak priorities of paint invalidation reasons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: NeedsRebaseline (for win and mac) Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutObject.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.h b/third_party/WebKit/Source/core/layout/LayoutObject.h
index 1d8e50943ea4e6769357826b1a6a10892cd9dc1e..a724a4914c60075d5e8cf17fdd12fc570187276b 100644
--- a/third_party/WebKit/Source/core/layout/LayoutObject.h
+++ b/third_party/WebKit/Source/core/layout/LayoutObject.h
@@ -1123,11 +1123,11 @@ public:
void invalidatePaintIncludingNonSelfPaintingLayerDescendants(const LayoutBoxModelObject& paintInvalidationContainer);
void setShouldDoFullPaintInvalidationIncludingNonCompositingDescendants();
- // Returns true if the object will not generate any effective painted output.
+ // Returns true if the object will not generate any effective painted output regardless of current size.
pdr. 2016/08/15 23:37:42 The text you wrote in your change description was
Xianzhu 2016/08/16 01:13:54 Done (with a slightly different explanation).
// It's used to skip unforced paint invalidation (which is when shouldDoFullPaintInvalidation
// is false, but mayNeedPaintInvalidation or childShouldCheckForPaintInvalidation is true) to
// avoid unnecessary paint invalidations of empty areas covered by such objects.
- virtual bool paintedOutputOfObjectHasNoEffect() const { return false; }
+ virtual bool paintedOutputOfObjectHasNoEffectRegardlessOfSize() const { return false; }
// Returns the rect that should have paint invalidated whenever this object changes. The rect is in the view's
// coordinate space. This method deals with outlines and overflow.

Powered by Google App Engine
This is Rietveld 408576698