Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2247543003: Tweak priorities of paint invalidation reasons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: NeedsRebaseline (for win and mac) Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved. 7 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 2026 matching lines...) Expand 10 before | Expand all | Expand 10 after
2037 bool LayoutBox::needsForcedBreakBefore(EBreak previousBreakAfterValue) const 2037 bool LayoutBox::needsForcedBreakBefore(EBreak previousBreakAfterValue) const
2038 { 2038 {
2039 // Forced break values are only honored when specified on in-flow objects, b ut floats and 2039 // Forced break values are only honored when specified on in-flow objects, b ut floats and
2040 // out-of-flow positioned objects may be affected by a break-after value of the previous 2040 // out-of-flow positioned objects may be affected by a break-after value of the previous
2041 // in-flow object, even though we're not at a class A break point. 2041 // in-flow object, even though we're not at a class A break point.
2042 EBreak breakValue = isFloatingOrOutOfFlowPositioned() 2042 EBreak breakValue = isFloatingOrOutOfFlowPositioned()
2043 ? previousBreakAfterValue : classABreakPointValue(previousBreakAfterValu e); 2043 ? previousBreakAfterValue : classABreakPointValue(previousBreakAfterValu e);
2044 return isForcedFragmentainerBreakValue(breakValue); 2044 return isForcedFragmentainerBreakValue(breakValue);
2045 } 2045 }
2046 2046
2047 bool LayoutBox::paintedOutputOfObjectHasNoEffect() const 2047 bool LayoutBox::paintedOutputOfObjectHasNoEffectRegardlessOfSize() const
2048 { 2048 {
2049 // In case scrollbars got repositioned (which will typically happen if the b ox got 2049 // In case scrollbars got repositioned (which will typically happen if the b ox got
2050 // resized), we cannot skip invalidation. 2050 // resized), we cannot skip invalidation.
2051 if (hasNonCompositedScrollbars()) 2051 if (hasNonCompositedScrollbars())
2052 return false; 2052 return false;
2053 2053
2054 // Cannot skip paint invalidation if the box has real things to paint. 2054 // Cannot skip paint invalidation if the box has real things to paint.
2055 if (getSelectionState() != SelectionNone || hasBoxDecorationBackground() || styleRef().hasBoxDecorations() || styleRef().hasVisualOverflowingEffect()) 2055 if (getSelectionState() != SelectionNone || hasBoxDecorationBackground() || styleRef().hasBoxDecorations() || styleRef().hasVisualOverflowingEffect())
2056 return false; 2056 return false;
2057 2057
(...skipping 2727 matching lines...) Expand 10 before | Expand all | Expand 10 after
4785 m_rareData->m_snapAreas->remove(&snapArea); 4785 m_rareData->m_snapAreas->remove(&snapArea);
4786 } 4786 }
4787 } 4787 }
4788 4788
4789 SnapAreaSet* LayoutBox::snapAreas() const 4789 SnapAreaSet* LayoutBox::snapAreas() const
4790 { 4790 {
4791 return m_rareData ? m_rareData->m_snapAreas.get() : nullptr; 4791 return m_rareData ? m_rareData->m_snapAreas.get() : nullptr;
4792 } 4792 }
4793 4793
4794 } // namespace blink 4794 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698