Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 22475011: Ignore an unsuitable test under deopt fuzz. (Closed)

Created:
7 years, 4 months ago by Michael Achenbach
Modified:
7 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Ignore an unsuitable test under deopt fuzz. That test relies on certain optimization/deoptimization points and is therefore not useful for the deopt fuzzer. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16145

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M test/mjsunit/mjsunit.status View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
7 years, 4 months ago (2013-08-12 07:20:08 UTC) #1
Michael Starzinger
LGTM with a comment. https://codereview.chromium.org/22475011/diff/1/test/mjsunit/mjsunit.status File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/22475011/diff/1/test/mjsunit/mjsunit.status#newcode253 test/mjsunit/mjsunit.status:253: compiler/escape-analysis: SKIP This might be ...
7 years, 4 months ago (2013-08-12 07:45:32 UTC) #2
Michael Achenbach
7 years, 4 months ago (2013-08-12 08:59:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16145.

Powered by Google App Engine
This is Rietveld 408576698