Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 22475010: Copy SpellChecker.{cpp,h} to SpellCheckRequester.{cpp.h} (Closed)

Created:
7 years, 4 months ago by yosin_UTC9
Modified:
7 years, 4 months ago
Reviewers:
tkent, ojan
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, ojan
Visibility:
Public.

Description

Copy SpellChecker.{cpp,h} to SpellCheckRequester.{cpp.h} Regarding ojan@'s suggestion(https://codereview.chromium.org/22732003/), this patch reverts r155831 which copies SpellChcker.{cpp,h} to SpellCheckerRequestManager.{cpp,h}, and copies SpellChecker.{cpp,h} to SpellCheckRequester.{cpp.h} for preparation of renaming SpellChecker class to SpellCheckRequester, to make class name more explicitly denotes what it does, and free its name to use name SpellChecker for decoupling spell checking and Editor class. Note: Differences between original file and new file are for style checking in pre-submit. BUG=n/a Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155920

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -387 lines) Patch
D Source/core/editing/SpellCheckRequestManager.h View 1 chunk +0 lines, -121 lines 0 comments Download
D Source/core/editing/SpellCheckRequestManager.cpp View 1 chunk +0 lines, -262 lines 0 comments Download
A + Source/core/editing/SpellCheckRequester.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + Source/core/editing/SpellCheckRequester.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
yosin_UTC9
Could you review this patch? Thanks in advance. We'll use SpellCheckRequester rather than SpellCheckRequestManager. Blink ...
7 years, 4 months ago (2013-08-12 02:05:39 UTC) #1
ojan
lgtm. thanks! On Sun, Aug 11, 2013 at 7:05 PM, <yosin@chromium.org> wrote: > Reviewers: tkent, ...
7 years, 4 months ago (2013-08-12 02:38:31 UTC) #2
yosin_UTC9
7 years, 4 months ago (2013-08-12 03:22:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r155920 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698