Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: tools/perf/measurements/smoothness.py

Issue 22475007: telemetry: separated stats collection from metrics calculation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/metrics/benchmark_stats.py » ('j') | tools/perf/metrics/benchmark_stats.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/smoothness.py
diff --git a/tools/perf/measurements/smoothness.py b/tools/perf/measurements/smoothness.py
index 71070b19978abc1c5b7e97cdeb17ead87718d12e..d1ef028c64ff686b7503490279c77ee74f35231b 100644
--- a/tools/perf/measurements/smoothness.py
+++ b/tools/perf/measurements/smoothness.py
@@ -3,6 +3,7 @@
# found in the LICENSE file.
from metrics import loading
from metrics import smoothness
+from metrics.benchmark_stats import MakeBenchmarkStats
from telemetry.page import page_measurement
class DidNotScrollException(page_measurement.MeasurementFailure):
@@ -59,11 +60,9 @@ class Smoothness(page_measurement.PageMeasurement):
loading.AddResultsForTab(tab, results)
smoothness.CalcFirstPaintTimeResults(results, tab)
- smoothness.CalcScrollResults(rendering_stats_deltas, results)
- smoothness.CalcTextureUploadResults(rendering_stats_deltas, results)
- smoothness.CalcImageDecodingResults(rendering_stats_deltas, results)
- smoothness.CalcAnalysisResults(rendering_stats_deltas, results)
- smoothness.CalcLatencyResults(rendering_stats_deltas, results)
+
+ benchmark_stats = MakeBenchmarkStats(rendering_stats_deltas)
+ smoothness.CalcResults(benchmark_stats, results)
if self.options.report_all_results:
for k, v in rendering_stats_deltas.iteritems():
« no previous file with comments | « no previous file | tools/perf/metrics/benchmark_stats.py » ('j') | tools/perf/metrics/benchmark_stats.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698