[Mac] Clean up SadTabView and let SadTabController provide its content

chrome/browser/ui/cocoa/tab_contents/sad_tab_controller_unittest.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/debug/debugger.h"
 #import "base/mac/foundation_util.h"
 #include "base/mac/scoped_nsobject.h"
 #import "chrome/browser/ui/cocoa/cocoa_test_helper.h"
 #import "chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.h"
 #import "chrome/browser/ui/cocoa/tab_contents/sad_tab_view_cocoa.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "chrome/test/base/testing_profile.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/browser/web_contents_delegate.h"
 #import "ui/base/cocoa/controls/hyperlink_text_view.h"
 
 @interface SadTabView (ExposedForTesting)
 // Implementation is below.
 - (HyperlinkTextView*)helpTextView;
 @end
 
 @implementation SadTabView (ExposedForTesting)
 - (HyperlinkTextView*)helpTextView {
   NSView* containerView = [[self subviews] lastObject];
   for (NSView* view in [containerView subviews]) {
     if (auto textView = base::mac::ObjCCast<HyperlinkTextView>(view))
       return textView;
   }
   return nil;
 }
 @end
 
 namespace {
 
+struct ContentsDelegate : public content::WebContentsDelegate {

[Avi (use Gerrit), 2016/08/12 23:06:22]

This should be a class.

https://google.github.io/styleguide/cppguide.html#Structs_vs._Classes

[Sidney San Martín, 2016/08/12 23:35:10]

Done.

+  GURL opened_url;
+
+  content::WebContents* OpenURLFromTab(
+      content::WebContents* source,
+      const content::OpenURLParams& params) override {
+    opened_url = params.url;
+    return nullptr;
+  }
+};
+
 class SadTabControllerTest : public ChromeRenderViewHostTestHarness {
  public:
-  SadTabControllerTest() : test_window_(nil) {
-    link_clicked_ = false;
-  }
+  SadTabControllerTest() : test_window_(nil) {}
 
   void SetUp() override {
     ChromeRenderViewHostTestHarness::SetUp();
+    web_contents()->SetDelegate(&contents_delegate_);
     // Inherting from ChromeRenderViewHostTestHarness means we can't inherit
     // from from CocoaTest, so do a bootstrap and create test window.
     CocoaTest::BootstrapCocoa();
     test_window_ = [[CocoaTestHelperWindow alloc] init];
     if (base::debug::BeingDebugged()) {
       [test_window_ orderFront:nil];
     } else {
       [test_window_ orderBack:nil];
     }
   }
@@ skipping 15 matching lines @@
     [contentView addSubview:view];
 
     return controller;
   }
 
   HyperlinkTextView* GetHelpTextView(SadTabController* controller) {
     SadTabView* view = static_cast<SadTabView*>([controller view]);
     return ([view helpTextView]);
   }
 
-  static bool link_clicked_;
+  ContentsDelegate contents_delegate_;
   CocoaTestHelperWindow* test_window_;
 };
 
-// static
-bool SadTabControllerTest::link_clicked_;
-
 TEST_F(SadTabControllerTest, ClickOnLink) {
   base::scoped_nsobject<SadTabController> controller(CreateController());
   HyperlinkTextView* help = GetHelpTextView(controller);
   EXPECT_TRUE(help);
-  EXPECT_FALSE(link_clicked_);
+  EXPECT_TRUE(contents_delegate_.opened_url.is_empty());
   [help clickedOnLink:@(chrome::kCrashReasonURL) atIndex:0];
-  EXPECT_TRUE(link_clicked_);
+  EXPECT_EQ(contents_delegate_.opened_url, GURL(chrome::kCrashReasonURL));
 }
 
 }  // namespace
-
-@implementation NSApplication (SadTabControllerUnitTest)
-// Add handler for the openLearnMoreAboutCrashLink: action to NSApp for testing
-// purposes. Normally this would be sent up the responder tree correctly, but
-// since tests run in the background, key window and main window are never set
-// on NSApplication. Adding it to NSApplication directly removes the need for
-// worrying about what the current window with focus is.
-- (void)openLearnMoreAboutCrashLink:(id)sender {
-  SadTabControllerTest::link_clicked_ = true;
-}
-
-@end