Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2247443002: Adds settings.cfg for gce-backend. (Closed)

Created:
4 years, 4 months ago by ryanmartens
Modified:
4 years, 4 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, smut_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-py@gce_config_refactor
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Adds settings.cfg for gce-backend. Adds option to enable/disable gae_ts_monitoring. R=maruel@chromium.org BUG= Committed: https://github.com/luci/luci-py/commit/00ada75760fec76c931ace4a192eeb8a024ba421

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -1 line) Patch
M appengine/gce-backend/config.py View 1 3 chunks +24 lines, -0 lines 0 comments Download
M appengine/gce-backend/main.py View 2 chunks +6 lines, -1 line 0 comments Download
A + appengine/gce-backend/proto/Makefile View 0 chunks +-1 lines, --1 lines 0 comments Download
M appengine/gce-backend/proto/config.proto View 1 chunk +7 lines, -0 lines 0 comments Download
M appengine/gce-backend/proto/config_pb2.py View 4 chunks +36 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 2243923002 Patch 60001

Messages

Total messages: 8 (3 generated)
ryanmartens
4 years, 4 months ago (2016-08-12 17:31:55 UTC) #1
M-A Ruel
lgtm https://codereview.chromium.org/2247443002/diff/1/appengine/gce-backend/config.py File appengine/gce-backend/config.py (right): https://codereview.chromium.org/2247443002/diff/1/appengine/gce-backend/config.py#newcode153 appengine/gce-backend/config.py:153: SETTINGS_CFG_FILENAME, config_pb2.SettingsCfg, store_last_good=True) align arguments at +4
4 years, 4 months ago (2016-08-12 19:24:25 UTC) #2
ryanmartens
https://codereview.chromium.org/2247443002/diff/1/appengine/gce-backend/config.py File appengine/gce-backend/config.py (right): https://codereview.chromium.org/2247443002/diff/1/appengine/gce-backend/config.py#newcode153 appengine/gce-backend/config.py:153: SETTINGS_CFG_FILENAME, config_pb2.SettingsCfg, store_last_good=True) On 2016/08/12 19:24:25, M-A Ruel wrote: ...
4 years, 4 months ago (2016-08-16 17:11:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2247443002/20001
4 years, 4 months ago (2016-08-16 17:20:50 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 17:22:50 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/00ada75760fec76c931ace4a192eeb8a024ba421

Powered by Google App Engine
This is Rietveld 408576698