Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 2247413003: GN: make current_cpu work (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
anmittal, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: make current_cpu work Then we can use it to remind ourselves that SSE and AVX are x86-only. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2247413003 Committed: https://skia.googlesource.com/skia/+/422310ddbe4db616200a949adcac2c560685030c

Patch Set 1 #

Patch Set 2 : update BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -26 lines) Patch
M BUILD.gn View 1 4 chunks +36 lines, -26 lines 0 comments Download
M gn/BUILDCONFIG.gn View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
mtklein_C
Does this work for you?
4 years, 4 months ago (2016-08-17 01:08:25 UTC) #6
anmittal
On 2016/08/17 01:08:25, mtklein_C wrote: > Does this work for you? yeah thanks that should ...
4 years, 4 months ago (2016-08-17 01:19:33 UTC) #7
anmittal
lgtm
4 years, 4 months ago (2016-08-17 01:19:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2247413003/20001
4 years, 4 months ago (2016-08-17 01:27:58 UTC) #11
mtklein
Cool! Now I imagine the next thing you'll encounter is a bunch of missing symbols ...
4 years, 4 months ago (2016-08-17 01:28:42 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/422310ddbe4db616200a949adcac2c560685030c
4 years, 4 months ago (2016-08-17 01:28:48 UTC) #14
anmittal
4 years, 4 months ago (2016-08-17 01:45:01 UTC) #15
Message was sent while issue was closed.
On 2016/08/17 01:28:42, mtklein wrote:
> Cool!  Now I imagine the next thing you'll encounter is a bunch of missing
> symbols for NEON code.  Keep the patches coming!

thanks !!!

Powered by Google App Engine
This is Rietveld 408576698