Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: media/filters/ffmpeg_video_decoder_unittest.cc

Issue 2247403002: Assign color spaces to video frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test added Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/ffmpeg_video_decoder_unittest.cc
diff --git a/media/filters/ffmpeg_video_decoder_unittest.cc b/media/filters/ffmpeg_video_decoder_unittest.cc
index e0f0b99a6b27028f0619eb2633cc3ec2b11aca5f..2e2746bd193a3ca30c9f6192c14d14fbea923304 100644
--- a/media/filters/ffmpeg_video_decoder_unittest.cc
+++ b/media/filters/ffmpeg_video_decoder_unittest.cc
@@ -363,4 +363,56 @@ TEST_F(FFmpegVideoDecoderTest, Destroy_EndOfStream) {
Destroy();
}
+TEST(GfxColorSpaceEnumTest, MakeSureEnumsLineUpWithFFMPEG) {
DaleCurtis 2016/08/16 22:22:17 You should be able to just do this with a static_a
hubbe 2016/08/16 22:38:16 Done.
+#define TEST_PRIMARY(P) \
+ EXPECT_EQ(static_cast<int>(gfx::ColorSpace::PrimaryID::P), AVCOL_PRI_##P)
+#define TEST_TRANSFER(T) \
+ EXPECT_EQ(static_cast<int>(gfx::ColorSpace::TransferID::T), AVCOL_TRC_##T)
+#define TEST_COLORSPACE(C) \
+ EXPECT_EQ(static_cast<int>(gfx::ColorSpace::MatrixID::C), AVCOL_SPC_##C)
+
+ TEST_PRIMARY(RESERVED0);
+ TEST_PRIMARY(BT709);
+ TEST_PRIMARY(UNSPECIFIED);
+ TEST_PRIMARY(RESERVED);
+ TEST_PRIMARY(BT470M);
+ TEST_PRIMARY(BT470BG);
+ TEST_PRIMARY(SMPTE170M);
+ TEST_PRIMARY(SMPTE240M);
+ TEST_PRIMARY(FILM);
+ TEST_PRIMARY(BT2020);
+ TEST_PRIMARY(SMPTEST428_1);
+
+ TEST_TRANSFER(RESERVED0);
+ TEST_TRANSFER(BT709);
+ TEST_TRANSFER(UNSPECIFIED);
+ TEST_TRANSFER(RESERVED);
+ TEST_TRANSFER(GAMMA22);
+ TEST_TRANSFER(GAMMA28);
+ TEST_TRANSFER(SMPTE170M);
+ TEST_TRANSFER(SMPTE240M);
+ TEST_TRANSFER(LINEAR);
+ TEST_TRANSFER(LOG);
+ TEST_TRANSFER(LOG_SQRT);
+ TEST_TRANSFER(IEC61966_2_4);
+ TEST_TRANSFER(BT1361_ECG);
+ TEST_TRANSFER(IEC61966_2_1);
+ TEST_TRANSFER(BT2020_10);
+ TEST_TRANSFER(BT2020_12);
+ TEST_TRANSFER(SMPTEST2084);
+ TEST_TRANSFER(SMPTEST428_1);
+
+ TEST_COLORSPACE(RGB);
+ TEST_COLORSPACE(BT709);
+ TEST_COLORSPACE(UNSPECIFIED);
+ TEST_COLORSPACE(RESERVED);
+ TEST_COLORSPACE(FCC);
+ TEST_COLORSPACE(BT470BG);
+ TEST_COLORSPACE(SMPTE170M);
+ TEST_COLORSPACE(SMPTE240M);
+ TEST_COLORSPACE(YCOCG);
+ TEST_COLORSPACE(BT2020_NCL);
+ TEST_COLORSPACE(BT2020_CL);
+}
+
} // namespace media

Powered by Google App Engine
This is Rietveld 408576698