Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 22474010: Create a gypi that contains all the SK_API header files for use by clients (i.e. chromium). (Closed)

Created:
7 years, 4 months ago by djsollen
Modified:
7 years, 4 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Create a gypi that contains all the SK_API header files for use by clients (i.e. chromium). R=robertphillips@google.com, torne@chromium.org Committed: https://code.google.com/p/skia/source/detail?r=10637

Patch Set 1 #

Patch Set 2 : add variables wrapper #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -0 lines) Patch
A gyp/exported_api_headers.gypi View 1 1 chunk +133 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
djsollen
torne, is this the format that you need or should I have it wrapped in ...
7 years, 4 months ago (2013-08-07 20:57:39 UTC) #1
Torne
On 2013/08/07 20:57:39, djsollen wrote: > torne, is this the format that you need or ...
7 years, 4 months ago (2013-08-07 21:33:32 UTC) #2
djsollen
torne, you might want to drop this on your machine and test it out, but ...
7 years, 4 months ago (2013-08-08 12:08:29 UTC) #3
robertphillips
lgtm
7 years, 4 months ago (2013-08-08 12:17:57 UTC) #4
Torne
lgtm
7 years, 4 months ago (2013-08-08 12:22:23 UTC) #5
robertphillips
Derek: do we already have an issue with the Skia Infrastructure team for the automation?
7 years, 4 months ago (2013-08-08 12:23:47 UTC) #6
djsollen
Committed patchset #2 manually as r10637 (presubmit successful).
7 years, 4 months ago (2013-08-08 12:31:09 UTC) #7
djsollen
We have an issue for the automation filed at... https://code.google.com/p/skia/issues/detail?id=1489
7 years, 4 months ago (2013-08-08 12:36:24 UTC) #8
tfarina
can we take a "different" approach here? I'd like to follow the same pattern as ...
7 years, 4 months ago (2013-08-08 23:47:04 UTC) #9
Torne
7 years, 4 months ago (2013-08-09 14:19:24 UTC) #10
Message was sent while issue was closed.
Hm, I've just tested this more carefully and it doesn't actually work; the list
doesn't include SkDraw, SkSize or SkThread.h from include/core, all of which are
included by files in src/skia/ext in Chromium..

Powered by Google App Engine
This is Rietveld 408576698