Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Unified Diff: lib/IR/InlineAsm.cpp

Issue 22474008: Add the new @llvm.nacl.atomic.fence.all intrinsic (Closed) Base URL: http://git.chromium.org/native_client/pnacl-llvm.git@master
Patch Set: Make isAsmMemory a member of InlineAsm as suggested by eliben. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/Analysis/NaCl/PNaClABIVerifyModule.cpp ('k') | lib/IR/NaClAtomicIntrinsics.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/IR/InlineAsm.cpp
diff --git a/lib/IR/InlineAsm.cpp b/lib/IR/InlineAsm.cpp
index 9f2a9fea4b93b1bd6ff4f65d16f952caf4bbd5a5..121fe1528ebd604c96cecba628afdd4c5fa0eb34 100644
--- a/lib/IR/InlineAsm.cpp
+++ b/lib/IR/InlineAsm.cpp
@@ -293,3 +293,18 @@ bool InlineAsm::Verify(FunctionType *Ty, StringRef ConstStr) {
return true;
}
+// @LOCALMOD-START
+bool InlineAsm::isAsmMemory() const {
+ bool retVoid = getFunctionType()->getReturnType()->isVoidTy();
+ bool noArgs = getFunctionType()->getNumParams() == 0 &&
+ !getFunctionType()->isVarArg();
+ bool isEmptyAsm = AsmString.empty();
+ // Different triples will encode "touch everything" differently, e.g.:
+ // - le32-unknown-nacl has "~{memory}".
+ // - x86 "~{memory},~{dirflag},~{fpsr},~{flags}".
jvoung (off chromium) 2013/08/07 22:32:11 Does that mean that in the backend, we need to con
JF 2013/08/07 22:47:41 Kind of. It comes from Clang's TargetInfo getClobb
+ // The following code therefore only searches for memory.
+ bool touchesMemory = Constraints.find("~{memory}") != std::string::npos;
+
+ return retVoid && noArgs && hasSideEffects() && isEmptyAsm && touchesMemory;
+}
+// @LOCALMOD-END
« no previous file with comments | « lib/Analysis/NaCl/PNaClABIVerifyModule.cpp ('k') | lib/IR/NaClAtomicIntrinsics.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698