Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: scripts/slave/recipe_modules/chromium_tests/steps.py

Issue 2247373002: Refactor stages 1, 2 and test_api overhaul. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Addressing all early feedback. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium_tests/steps.py
diff --git a/scripts/slave/recipe_modules/chromium_tests/steps.py b/scripts/slave/recipe_modules/chromium_tests/steps.py
index a67bb356e0e7cb6c155c5e58dc5cf2366a1cf3a1..e62d6e100a1be4309538ac4012026f5bf89e8a4d 100644
--- a/scripts/slave/recipe_modules/chromium_tests/steps.py
+++ b/scripts/slave/recipe_modules/chromium_tests/steps.py
@@ -1288,9 +1288,11 @@ class PrintPreviewTests(PythonBasedTest): # pylint: disable=W032
class BisectTest(Test): # pylint: disable=W0232
name = 'bisect_test'
- def __init__(self, test_parameters={}):
+ def __init__(self, test_parameters={}, **kwargs):
super(BisectTest, self).__init__()
self._test_parameters = test_parameters
+ self.run_results = {}
+ self.kwargs = kwargs
@property
def abort_on_failure(self):
@@ -1310,17 +1312,11 @@ class BisectTest(Test): # pylint: disable=W0232
api.properties.get('bisect_config')))
def run(self, api, _, test_filter=None):
- self._run_results, self.test_output, self.retcodes = (
- api.bisect_tester.run_test(self.test_config))
-
- def post_run(self, api, _, test_filter=None):
- self.values = api.bisect_tester.digest_run_results(
- self._run_results, self.retcodes, self.test_config)
- api.bisect_tester.upload_results(self.test_output, self.values,
- self.retcodes, self._test_parameters)
+ self.run_results = api.bisect_tester.run_test(self.test_config,
+ **self.kwargs)
def has_valid_results(self, *_):
- return len(getattr(self, 'values', [])) > 0 # pragma: no cover
+ return bool(self.run_results.get('retcodes')) # pragma: no cover
def failures(self, *_):
return self._failures # pragma: no cover

Powered by Google App Engine
This is Rietveld 408576698