Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: scripts/slave/recipe_modules/chromium/api.py

Issue 2247373002: Refactor stages 1, 2 and test_api overhaul. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Rebasing, addressing feedback. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium/api.py
diff --git a/scripts/slave/recipe_modules/chromium/api.py b/scripts/slave/recipe_modules/chromium/api.py
index 56759ccd142e979005fce95c549c6466bbe5db0f..bfca965775ad1c87a6bf72b363928e86bb7ca235 100644
--- a/scripts/slave/recipe_modules/chromium/api.py
+++ b/scripts/slave/recipe_modules/chromium/api.py
@@ -320,7 +320,7 @@ class ChromiumApi(recipe_api.RecipeApi):
full_args.append('--test-type=%s' % test_type)
step_name = name or t_name
full_args.append('--step-name=%s' % step_name)
- if chartjson_file:
+ if chartjson_file and not 'step_test_data' in kwargs:
full_args.append('--chartjson-file')
full_args.append(self.m.json.output())
kwargs['step_test_data'] = lambda: self.m.json.test_api.output([])

Powered by Google App Engine
This is Rietveld 408576698