Refactor stages 1, 2 and test_api overhaul.

scripts/slave/recipes/bisection/desktop_bisect.py

Index: scripts/slave/recipes/bisection/desktop_bisect.py
diff --git a/scripts/slave/recipes/bisection/desktop_bisect.py b/scripts/slave/recipes/bisection/desktop_bisect.py
index 917074ef9621f302226655acebc2e216e3d27f0d..20944d448d01feeda3a2e48b3d137d3dde51c868 100644
--- a/scripts/slave/recipes/bisection/desktop_bisect.py
+++ b/scripts/slave/recipes/bisection/desktop_bisect.py
@@ -36,10 +36,13 @@ def RunSteps(api):
 
 
 def GenTests(api):
-  yield (api.test('basic') + api.properties.tryserver(
-      path_config='kitchen',
-      mastername='tryserver.chromium.perf',
-      buildername='linux_perf_bisect') + api.override_step_data(
+  yield (
+      api.test('basic') +
+      api.properties.tryserver(
+          path_config='kitchen',
+          mastername='tryserver.chromium.perf',
+          buildername='linux_perf_bisect') +
+      api.override_step_data(
           'git diff to analyze patch',
           api.raw_io.stream_output('tools/auto_bisect/bisect.cfg')))
 
@@ -326,57 +329,3 @@ results-without_patch
       api.step_data('buildbucket.get',
               stdout=api.json.output(buildbucket_get_response)))
 
-  bisect_config = {
-      'test_type': 'perf',
-      'command': './tools/perf/run_benchmark -v '
-                 '--browser=release page_cycler.intl_ar_fa_he',
-      'metric': 'warm_times/page_load_time',
-      'repeat_count': '2',
-      'max_time_minutes': '5',
-      'truncate_percent': '25',
-      'bug_id': '425582',
-      'gs_bucket': 'chrome-perf',
-      'builder_host': 'master4.golo.chromium.org',
-      'builder_port': '8341',
-  }
-  yield (

[eakuefner, 2016/09/09 20:35:42]

What happens to the test coverage that you're deleting here? Is it still covered
elsewhere?

[RobertoCN, 2016/09/13 22:11:40]

Yeah. I am overall reducing the amount of non-covered code because I adding
almost no new `# pragma: no cover`s and I am removing many. Also these tests are
being removed because either: the code that they tested is being removed, or the
way we generated test data was overly complicated.

-      api.test('basic_linux_bisect_tester_recipe') + api.properties.tryserver(
-          path_config='kitchen',
-          mastername='tryserver.chromium.perf',
-          buildername='linux_perf_bisect') + api.step_data(
-              'saving url to temp file',
-              stdout=api.raw_io.output('/tmp/dummy1')) + api.step_data(
-                  'saving json to temp file',
-                  stdout=api.raw_io.output('/tmp/dummy2')) + api.properties(
-                      bisect_config=bisect_config) + api.properties(
-                          job_name='f7a7b4135624439cbd27fdd5133d74ec') +
-      api.bisect_tester(tempfile='/tmp/dummy') + api.properties(
-          parent_got_revision='1111111') + api.properties(
-              parent_build_archive_url='gs://test-domain/test-archive.zip'))
-
-  bisect_ret_code_config = {
-      'test_type': 'return_code',
-      'command': './tools/perf/run_benchmark -v '
-                 '--browser=release page_cycler.intl_ar_fa_he',
-      'metric': 'warm_times/page_load_time',
-      'repeat_count': '2',
-      'max_time_minutes': '5',
-      'truncate_percent': '25',
-      'bug_id': '425582',
-      'gs_bucket': 'chrome-perf',
-      'builder_host': 'master4.golo.chromium.org',
-      'builder_port': '8341',
-  }
-  yield (api.test('basic_linux_bisect_tester_recipe_ret_code') +
-         api.properties.tryserver(path_config='kitchen',
-                                  mastername='tryserver.chromium.perf',
-                                  buildername='linux_perf_bisect') +
-         api.step_data('saving url to temp file',
-                       stdout=api.raw_io.output('/tmp/dummy1')) + api.step_data(
-                           'saving json to temp file',
-                           stdout=api.raw_io.output('/tmp/dummy2')) +
-         api.properties(bisect_config=bisect_ret_code_config) + api.properties(
-             job_name='f7a7b4135624439cbd27fdd5133d74ec') +
-         api.bisect_tester(tempfile='/tmp/dummy') + api.properties(
-             parent_got_revision='1111111') + api.properties(
-                 parent_build_archive_url='gs://test-domain/test-archive.zip'))