scripts/slave/recipe_modules/chromium/api.py - Issue 2247373002: Refactor stages 1, 2 and test_api overhaul.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium/api.py

Issue 2247373002: Refactor stages 1, 2 and test_api overhaul. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Got full coverage for new and changed code. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/auto_bisect/bisector.py ('K') | « scripts/slave/recipe_modules/bisect_tester/perf_test.py ('k') | scripts/slave/recipe_modules/chromium_tests/steps.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/chromium/api.py

diff --git a/scripts/slave/recipe_modules/chromium/api.py b/scripts/slave/recipe_modules/chromium/api.py

index 4bf16fcb1ff5d4fe022ec137d34b3812effcc745..d469d03fec80fde17f2ad8b0cae26170bb880e95 100644

--- a/scripts/slave/recipe_modules/chromium/api.py

+++ b/scripts/slave/recipe_modules/chromium/api.py

@@ -313,7 +313,7 @@ class ChromiumApi(recipe_api.RecipeApi):

full_args.append('--test-type=%s' % test_type)

step_name = name or t_name

full_args.append('--step-name=%s' % step_name)

- if chartjson_file:

+ if chartjson_file and not 'step_test_data' in kwargs:

full_args.append('--chartjson-file')

full_args.append(self.m.json.output())

kwargs['step_test_data'] = lambda: self.m.json.test_api.output([])