Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: scripts/slave/recipe_modules/chromium_tests/steps.py

Issue 2247373002: Refactor stages 1, 2 and test_api overhaul. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Relative intra-module imports. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium_tests/steps.py
diff --git a/scripts/slave/recipe_modules/chromium_tests/steps.py b/scripts/slave/recipe_modules/chromium_tests/steps.py
index ff6dd12322b9c92c43e9f1d3913c0c556fea823b..d0697c0fc2d9f3f4ee81580ebc25c0e61ff3148e 100644
--- a/scripts/slave/recipe_modules/chromium_tests/steps.py
+++ b/scripts/slave/recipe_modules/chromium_tests/steps.py
@@ -1423,21 +1423,42 @@ class BisectTest(Test): # pylint: disable=W0232
def failures(self, *_):
return self._failures # pragma: no cover
-class BisectTestStaging(BisectTest):
+
+class BisectTestStaging(Test): # pylint: disable=W0232
+ name = 'bisect_test_staging'
+
+ def __init__(self, test_parameters={}, **kwargs):
+ super(BisectTestStaging, self).__init__()
+ self._test_parameters = test_parameters
+ self.run_results = {}
+ self.kwargs = kwargs
+
+ @property
+ def abort_on_failure(self):
+ return True # pragma: no cover
+
+ @property
+ def uses_local_devices(self):
+ return False
+
+ @staticmethod
+ def compile_targets(_): # pragma: no cover
+ return ['chrome'] # Bisect always uses a separate bot for building.
+
def pre_run(self, api, _, test_filter=None):
self.test_config = api.bisect_tester_staging.load_config_from_dict(
self._test_parameters.get('bisect_config',
api.properties.get('bisect_config')))
def run(self, api, _, test_filter=None):
- self._run_results, self.test_output, self.retcodes = (
- api.bisect_tester_staging.run_test(self.test_config))
+ self.run_results = api.bisect_tester_staging.run_test(
+ self.test_config, **self.kwargs)
- def post_run(self, api, _, test_filter=None):
- self.values = api.bisect_tester_staging.digest_run_results(
- self._run_results, self.retcodes, self.test_config)
- api.bisect_tester_staging.upload_results(
- self.test_output, self.values, self.retcodes, self._test_parameters)
+ def has_valid_results(self, *_):
+ return bool(self.run_results.get('retcodes')) # pragma: no cover
+
+ def failures(self, *_):
+ return self._failures # pragma: no cover
class AndroidTest(Test):

Powered by Google App Engine
This is Rietveld 408576698