Refactor stages 1, 2 and test_api overhaul.

scripts/slave/recipes/bisect_test/example_bisect_results.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """This example file is meant to provide coverage to bisect_results."""
 
 DEPS = [
     'auto_bisect',
+    'gsutil',
     'recipe_engine/json',
     'recipe_engine/path',
     'recipe_engine/properties',
     'recipe_engine/raw_io',
 ]
 
 BASIC_CONFIG = {
     'test_type': 'perf',
     'command':
         ('src/tools/perf/run_benchmark -v --browser=release smoothness.'
@@ skipping 32 matching lines @@
 FAILED_DIRECTION_ATTRIBUTES = dict(BASIC_ATTRIBUTES)
 FAILED_DIRECTION_ATTRIBUTES['failed_direction'] = True
 FAILED_DIRECTION_ATTRIBUTES['culprit_present'] = False
 
 ABORTED_BISECT_ATTRIBUTES = dict(BASIC_ATTRIBUTES)
 ABORTED_BISECT_ATTRIBUTES['failed_initial_confidence'] = True
 ABORTED_BISECT_ATTRIBUTES['culprit_present'] = False
 
 
 def RunSteps(api):
+  # For coverage only
+  api.gsutil.cat('gs://fakebucket/fake/path/fake_file.txt')
+
   api.path['checkout'] = api.path.mkdtemp('bogus')
   bisector = api.auto_bisect.create_bisector(api.properties['bisect_config'],
                                              dummy_mode=True)
   # Load the simulated results of a bisect
   dummy_bisector_attributes = dict(api.properties['dummy_bisector_attributes'])
 
   # Simulate the side-effects of a bisect by setting the bisector attributes
   # directly.
   if dummy_bisector_attributes.pop('culprit_present'):
     bisector.culprit = bisector.bad_rev
@@ skipping 10 matching lines @@
                                      'other_attribute.nested_val': False})
   """
   for k, v in attributes.iteritems():
     if '.' in k:
       sub_target = getattr(target, k.split('.')[0])
       setattr(sub_target, k.split('.')[1], v)
     else:
       setattr(target, k, v)
 
 
-def add_revision_mapping(api, test, pos, sha):
-  step_name = ('Resolving reference range.crrev get commit hash for ' +
-               'refs/heads/master@{#%s}' % pos)
-  stdout = api.json.output({'git_sha': sha})
-  test += api.step_data(step_name, stdout=stdout)
-
-  step_name = 'Resolving reference range.resolving hash ' + sha
-  pos = 'refs/heads/master@{#%s}' % pos
-  stdout = api.raw_io.output(pos)
-  return test
-
-
 def add_revision_info(api, test):
   step_name = 'Reading culprit cl information.'
   rev_info = {
       'author': 'DummyAuthor',
       'email': 'dummy@nowhere.com',
       'subject': 'Some random CL',
       'date': '01/01/2015',
       'body': ('A long description for a CL.\n'
                'Containing multiple lines'),
   }
   return test + api.step_data(step_name, stdout=api.json.output(rev_info))
 
 
 def get_post_bisect_step_data(api, test):
   """Gets step data for perf_dashboard/resource/post_json.py."""
   response = {'status_code': 200}
   return test + api.step_data('Post bisect results',
                               stdout=api.json.output(response))
 
 
 def GenTests(api):
   basic_test = api.test('basic_test')
   basic_test = get_post_bisect_step_data(api, basic_test)
-  basic_test = add_revision_mapping(api, basic_test, '314015', 'c001c0de')
-  basic_test = add_revision_mapping(api, basic_test, '314017', 'deadbeef')
   basic_test = add_revision_info(api, basic_test)
   basic_test += api.properties(
       bisect_config = BASIC_CONFIG,
       dummy_bisector_attributes = BASIC_ATTRIBUTES)
+  basic_test += api.auto_bisect([
+      {'hash': 'c001c0de', 'commit_pos': '314015'},
+      {'hash': 'deadc0de', 'commit_pos': '314016'},
+      {'hash': 'deadbeef', 'commit_pos': '314017'},
+  ])
   yield basic_test
 
   deps_culprit_test = api.test('deps_culprit_test')
   deps_culprit_test = get_post_bisect_step_data(api, deps_culprit_test)
-  deps_culprit_test = add_revision_mapping(
-      api, deps_culprit_test, '314015', 'c001c0de')
-  deps_culprit_test = add_revision_mapping(
-      api, deps_culprit_test, '314017', 'deadbeef')
   deps_culprit_test = add_revision_info(api, deps_culprit_test)
   deps_culprit_test += api.properties(
       bisect_config = BASIC_CONFIG,
       dummy_bisector_attributes = DEPS_CULPRIT_ATTRIBUTES)
+  deps_culprit_test += api.auto_bisect([
+      {'hash': 'c001c0de', 'commit_pos': '314015'},
+      {'hash': 'deadc0de', 'commit_pos': '314016'},
+      {'hash': 'deadbeef', 'commit_pos': '314017'},
+  ])
   yield deps_culprit_test
 
   failed_test = api.test('failed_test')
   failed_test = get_post_bisect_step_data(api, failed_test)
-  failed_test = add_revision_mapping(api, failed_test, '314015', 'c001c0de')
-  failed_test = add_revision_mapping(api, failed_test, '314017', 'deadbeef')
   failed_test += api.properties(
       bisect_config = BASIC_CONFIG,
       dummy_bisector_attributes = FAILED_ATTRIBUTES)
+  failed_test += api.auto_bisect([
+      {'hash': 'c001c0de', 'commit_pos': '314015'},
+      {'hash': 'deadc0de', 'commit_pos': '314016'},
+      {'hash': 'deadbeef', 'commit_pos': '314017'},
+  ])
   yield failed_test
 
   failed_direction_test = api.test('failed_direction_test')
-  failed_direction_test = get_post_bisect_step_data(api,
-                                                    failed_direction_test)
-  failed_direction_test = add_revision_mapping(api, failed_direction_test,
-                                               '314015', 'c001c0de')
-  failed_direction_test = add_revision_mapping(api, failed_direction_test,
-                                               '314017', 'deadbeef')
+  failed_direction_test = get_post_bisect_step_data(
+      api, failed_direction_test)
   failed_direction_test += api.properties(
       bisect_config = BASIC_CONFIG,
       dummy_bisector_attributes = FAILED_DIRECTION_ATTRIBUTES)
+  failed_direction_test += api.auto_bisect([
+      {'hash': 'c001c0de', 'commit_pos': '314015'},
+      {'hash': 'deadc0de', 'commit_pos': '314016'},
+      {'hash': 'deadbeef', 'commit_pos': '314017'},
+  ])
   yield failed_direction_test
 
   aborted_bisect_test = api.test('aborted_non_telemetry_test')
   aborted_bisect_test = get_post_bisect_step_data(api, aborted_bisect_test)
-  aborted_bisect_test = add_revision_mapping(api, aborted_bisect_test, '314015',
-                                             'c001c0de')
-  aborted_bisect_test = add_revision_mapping(api, aborted_bisect_test, '314017',
-                                             'deadbeef')
   aborted_bisect_test += api.properties(
       bisect_config = NON_TELEMETRY_TEST_CONFIG,
       dummy_bisector_attributes = ABORTED_BISECT_ATTRIBUTES)
+  aborted_bisect_test += api.auto_bisect([
+      {'hash': 'c001c0de', 'commit_pos': '314015'},
+      {'hash': 'deadc0de', 'commit_pos': '314016'},
+      {'hash': 'deadbeef', 'commit_pos': '314017'},
+  ])
   yield aborted_bisect_test