Refactor stages 1, 2 and test_api overhaul.

scripts/slave/recipe_modules/perf_try/api.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """API for the perf try job recipe module.
 
 This API is meant to enable the perf try job recipe on any chromium-supported
 platform for any test that can be run via buildbot, perf or otherwise.
 """
 
@@ skipping 159 matching lines @@
       update_step = self.m.bot_update.ensure_checkout(
           suffix=str(revision), force=True, patch=False,
           update_presentation=False)
       assert update_step.json.output['did_run']
       self.m.chromium.runhooks(name='runhooks on %s' % str(revision))
 
     return update_step
 
   def _run_test(self, cfg, **kwargs):
     """Runs test from config and return results."""
-    values, overall_output, retcodes = self.m.bisect_tester.run_test(
+    run_results = self.m.bisect_tester.run_test(
         cfg, **kwargs)
-    all_values = self.m.bisect_tester.digest_run_results(values, retcodes, cfg)
+    all_values = self.m.bisect_tester.digest_run_results(run_results, cfg)
     overall_success = True
     if (not kwargs.get('allow_flakes', True) and
         cfg.get('test_type', 'perf') != 'return_code'):
-      overall_success = all(v == 0 for v in retcodes)
+      overall_success = all(v == 0 for v in run_results['retcodes'])
     return {
         'results': all_values,
         'ret_code': overall_success,
-        'output': ''.join(overall_output)
+        'output': ''.join(run_results['output'])
     }
 
   def _build_and_run_tests(self, cfg, update_step, bot_db, revision_hash,
                            **kwargs):
     """Compiles binaries and runs tests for a given a revision."""
     with_patch = kwargs.get('name') == 'With Patch'
     update_step = self._checkout_revision(update_step, bot_db, revision_hash)
     if update_step.presentation.properties:
       revision_hash = update_step.presentation.properties['got_revision']
     revision = build_state.BuildState(self, revision_hash, with_patch)
@@ skipping 301 matching lines @@
 
 def _prepend_src_to_path_in_command(test_cfg):
   command_to_run = []
   for v in test_cfg.get('command').split():
     if v in ['./tools/perf/run_benchmark',
              'tools/perf/run_benchmark',
              'tools\\perf\\run_benchmark']:
       v = 'src/tools/perf/run_benchmark'
     command_to_run.append(v)
   test_cfg.update({'command': ' '.join(command_to_run)})