Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: third_party/closure_compiler/run_compiler

Issue 2247353004: GN files for running Closure Compiler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add use of GN to run_compiler Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/closure_compiler/run_compiler
diff --git a/third_party/closure_compiler/run_compiler b/third_party/closure_compiler/run_compiler
index 884c41551c4f6a4583d86eeef1475b41c626af1c..b292233ea67bfd429d3ad8318db5224f2d12eeb5 100755
--- a/third_party/closure_compiler/run_compiler
+++ b/third_party/closure_compiler/run_compiler
@@ -14,3 +14,7 @@ third_party/closure_compiler/compiled_resources.gyp \
third_party/closure_compiler/compiled_resources2.gyp
ninja -C out/Default -j4 $@
+
+gn gen --args='root_extra_deps=["//third_party/closure_compiler:compile_js_all"]' out/Default
Dan Beam 2016/09/06 16:46:46 i don't think we want to: a) run both GN and GYP
aberent 2016/09/06 17:30:22 My thought was to take individual dependencies out
+
+ninja -C out/Default third_party/closure_compiler:compile_js_all

Powered by Google App Engine
This is Rietveld 408576698