GN files for running Closure Compiler

third_party/closure_compiler/compile2.py

 #!/usr/bin/python
 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Runs Closure compiler on JavaScript files to check for errors and produce
 minified output."""
 
 import argparse
 import os
@@ skipping 171 matching lines @@
       content: A string of the file contens to write to a temporary file.
 
     Return:
       The filepath of the newly created, written, and closed temporary file.
     """
     with tempfile.NamedTemporaryFile(mode="wt", delete=False) as tmp_file:
       self._temp_files.append(tmp_file.name)
       tmp_file.write(contents)
     return tmp_file.name
 
-  def check(self, sources, out_file=None, runner_args=None, closure_args=None,
+  def check(self,
+            sources,
+            source_list_file=None,

[Dan Beam, 2016/09/06 16:46:46]

can we call this like gn_source_list_file to make it clearer it's coming from a
format GN controls (and doesn't apply to the GYP version of this for the short
time it exists)?

[aberent, 2016/09/07 09:31:18]

Done.

+            out_file=None,
+            runner_args=None,
+            closure_args=None,
             custom_sources=True):
     """Closure compile |sources| while checking for errors.
 
     Args:
       sources: Files to check. sources[0] is the typically the target file.
           sources[1:] are externs and dependencies in topological order. Order
           is not guaranteed if custom_sources is True.
       out_file: A file where the compiled output is written to.
       runner_args: Arguments passed to runner.jar.
       closure_args: Arguments passed directly to the Closure compiler.
       custom_sources: Whether |sources| was customized by the target (e.g. not
           in GYP dependency order).
 
     Returns:
       (found_errors, stderr) A boolean indicating whether errors were found and
           the raw Closure compiler stderr (as a string).
     """
     is_extern = lambda f: 'extern' in f
     externs_and_deps = [self._POLYMER_EXTERNS]
+    
+    # Convert the sources to absolute paths to make comparisons easy.
+    sources = map(os.path.abspath, sources)
+    # Process the source list.
+    if (source_list_file):

[Dan Beam, 2016/09/06 16:46:46]

if source_list_file:

[aberent, 2016/09/07 09:31:18]

Done.

+      with open(source_list_file) as f:
+        listed_sources = f.read().splitlines()
+        # Ignore the first line, GN puts the output file name here
+        listed_sources = listed_sources[1:]
+        listed_sources = map(os.path.abspath, listed_sources)
+        # Concatenate onto sources, removing duplicates
+        sources += [x for x in listed_sources if x not in sources]
 
     if custom_sources:
       externs_and_deps += sources
     else:
       self._target = sources[0]
       externs_and_deps += sources[1:]
 
     externs = filter(is_extern, externs_and_deps)
     deps = filter(lambda f: not is_extern(f), externs_and_deps)
 
@@ skipping 78 matching lines @@
 
     self._nuke_temp_files()
     return bool(errors), stderr
 
 
 if __name__ == "__main__":
   parser = argparse.ArgumentParser(
       description="Typecheck JavaScript using Closure compiler")
   parser.add_argument("sources", nargs=argparse.ONE_OR_MORE,
                       help="Path to a source file to typecheck")
+  parser.add_argument(
+      "--source_list_file",
+      help="""A file generated by GN containing a list of
+              additional sources. Due to an oddity in how this is
+              generated the first line is ignored""")
   parser.add_argument("--custom_sources", action="store_true",
                       help="Whether this rules has custom sources.")
   parser.add_argument("-o", "--out_file",
                       help="A file where the compiled output is written to")
   parser.add_argument("-r", "--runner_args", nargs=argparse.ZERO_OR_MORE,
                       help="Arguments passed to runner.jar")
   parser.add_argument("-c", "--closure_args", nargs=argparse.ZERO_OR_MORE,
                       help="Arguments passed directly to the Closure compiler")
   parser.add_argument("-v", "--verbose", action="store_true",
                       help="Show more information as this script runs")
   opts = parser.parse_args()
 
   checker = Checker(verbose=opts.verbose)
 
-  found_errors, stderr = checker.check(opts.sources, out_file=opts.out_file,
+  found_errors, stderr = checker.check(opts.sources,
+                                       source_list_file = opts.source_list_file,

[Dan Beam, 2016/09/06 16:46:46]

no spaces between =, i.e. source_list_file=opts.source_list_file,

[aberent, 2016/09/07 09:31:18]

Done.

+                                       out_file=opts.out_file,
                                        closure_args=opts.closure_args,
                                        runner_args=opts.runner_args,
                                        custom_sources=opts.custom_sources)
 
   if found_errors:
     if opts.custom_sources:
       print stderr
     sys.exit(1)