Issue 224733022: Handlify CompilationCache.

Issue 224733022: Handlify CompilationCache. (Closed)

Created:
6 years, 8 months ago by ulan

Modified:
6 years, 8 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handlify CompilationCache. BUG= R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20578

Patch Set 2 : Add MaybeHandle #

Patch Set 3 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+167 lines, -277 lines)			Patch
M	src/compilation-cache.h	View	1 2	5 chunks	+13 lines, -50 lines	0 comments	Download
M	src/compilation-cache.cc	View	1 2	7 chunks	+38 lines, -100 lines	0 comments	Download
M	src/compiler.cc	View	1	3 chunks	+11 lines, -12 lines	0 comments	Download
M	src/jsregexp.cc	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/objects.h	View		1 chunk	+16 lines, -18 lines	0 comments	Download
M	src/objects.cc	View		7 chunks	+85 lines, -95 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM. https://codereview.chromium.org/224733022/diff/1/src/compilation-cache.cc File src/compilation-cache.cc (right): https://codereview.chromium.org/224733022/diff/1/src/compilation-cache.cc#newcode288 src/compilation-cache.cc:288: return Handle<SharedFunctionInfo>::null(); Maybe we also should return MaybeHandle ...

6 years, 8 months ago (2014-04-08 09:31:11 UTC) #2

ulan

Please take another look. https://codereview.chromium.org/224733022/diff/1/src/compilation-cache.cc File src/compilation-cache.cc (right): https://codereview.chromium.org/224733022/diff/1/src/compilation-cache.cc#newcode288 src/compilation-cache.cc:288: return Handle<SharedFunctionInfo>::null(); On 2014/04/08 09:31:11, ...

6 years, 8 months ago (2014-04-08 10:05:59 UTC) #3

ulan

6 years, 8 months ago (2014-04-08 12:33:51 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r20578 (presubmit successful).

Expand Messages | Collapse Messages