Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Unified Diff: content/renderer/render_view_impl.cc

Issue 224733018: Changes to content/ to facilitate new zoom extension API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/renderer/render_view_impl.h ('K') | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 26d6b53400e9b5a1075cd5ce463c1e418b156ea3..18795964fb037f5d7246836ddef0ec303db5c00a 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -3286,10 +3286,13 @@ void RenderViewImpl::OnZoom(PageZoom zoom) {
zoomLevelChanged();
}
-void RenderViewImpl::OnSetZoomLevel(double zoom_level) {
+void RenderViewImpl::OnSetZoomLevel(int zoom_id,
+ double zoom_level,
+ content::ZoomMode zoom_mode) {
webview()->hidePopups();
- webview()->setZoomLevel(zoom_level);
- zoomLevelChanged();
+ if (zoom_mode != content::kZoomModeManual)
+ webview()->setZoomLevel(zoom_level);
+ zoomLevelChanged(zoom_id, zoom_level, zoom_mode == content::kZoomModeDefault);
}
void RenderViewImpl::OnSetZoomLevelForLoadingURL(const GURL& url,
@@ -4342,15 +4345,19 @@ void RenderViewImpl::zoomLimitsChanged(double minimum_level,
}
void RenderViewImpl::zoomLevelChanged() {
- bool remember = !webview()->mainFrame()->document().isPluginDocument();
- float zoom_level = webview()->zoomLevel();
+ zoomLevelChanged(0, webview()->zoomLevel(), false);
+}
+
+void RenderViewImpl::zoomLevelChanged(int zoom_id, double zoom_level,
+ bool remember) {
+ remember = remember && !webview()->mainFrame()->document().isPluginDocument();
FOR_EACH_OBSERVER(RenderViewObserver, observers_, ZoomLevelChanged());
// Tell the browser which url got zoomed so it can update the menu and the
// saved values if necessary
Send(new ViewHostMsg_DidZoomURL(
- routing_id_, zoom_level, remember,
+ routing_id_, zoom_id, zoom_level, remember,
GURL(webview()->mainFrame()->document().url())));
}
« content/renderer/render_view_impl.h ('K') | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698