Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: content/child/service_worker/service_worker_dispatcher.cc

Issue 224733014: Introduce ServiceWorkerHandle for tracking WebServiceWorkerImpl reference (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/service_worker/service_worker_dispatcher.cc
diff --git a/content/child/service_worker/service_worker_dispatcher.cc b/content/child/service_worker/service_worker_dispatcher.cc
index 7c63e775116a573110dad8b94ea188774ed507d6..82a52fba45d3f5e12c30fcf9259cf7823009f1a5 100644
--- a/content/child/service_worker/service_worker_dispatcher.cc
+++ b/content/child/service_worker/service_worker_dispatcher.cc
@@ -116,7 +116,7 @@ ServiceWorkerDispatcher* ServiceWorkerDispatcher::ThreadSpecificInstance(
void ServiceWorkerDispatcher::OnRegistered(int thread_id,
int request_id,
- int64 registration_id,
+ int handle_id,
int64 version_id) {
WebServiceWorkerProvider::WebServiceWorkerCallbacks* callbacks =
pending_callbacks_.Lookup(request_id);
@@ -131,7 +131,7 @@ void ServiceWorkerDispatcher::OnRegistered(int thread_id,
// duplicate registration. So for now we mint a new object each
// time.
scoped_ptr<WebServiceWorkerImpl> worker(
- new WebServiceWorkerImpl(registration_id, version_id,
+ new WebServiceWorkerImpl(handle_id, version_id,
michaeln 2014/04/08 01:21:41 in cases were the message doesn't get far and no W
kinuko 2014/04/08 08:43:31 Done.
thread_safe_sender_));
callbacks->onSuccess(worker.release());
pending_callbacks_.Remove(request_id);

Powered by Google App Engine
This is Rietveld 408576698