content/child/service_worker/service_worker_dispatcher.cc - Issue 224733014: Introduce ServiceWorkerHandle for tracking WebServiceWorkerImpl reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/service_worker_dispatcher.cc

Issue 224733014: Introduce ServiceWorkerHandle for tracking WebServiceWorkerImpl reference (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: sigh, rebased Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/service_worker/service_worker_dispatcher.h ('k') | content/child/service_worker/service_worker_message_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/service_worker/service_worker_dispatcher.cc

diff --git a/content/child/service_worker/service_worker_dispatcher.cc b/content/child/service_worker/service_worker_dispatcher.cc

index 22bc166175571059286ff5c62c6c8c21e4b3d2b4..991efe36fe19d937ee53bda101b7b8a0a751922d 100644

--- a/content/child/service_worker/service_worker_dispatcher.cc

+++ b/content/child/service_worker/service_worker_dispatcher.cc

@@ -114,7 +114,7 @@ ServiceWorkerDispatcher* ServiceWorkerDispatcher::ThreadSpecificInstance(

void ServiceWorkerDispatcher::OnRegistered(int32 thread_id,

int32 request_id,

- int64 version_id) {

+ int handle_id) {

WebServiceWorkerProvider::WebServiceWorkerCallbacks* callbacks =

pending_callbacks_.Lookup(request_id);

DCHECK(callbacks);

@@ -128,7 +128,7 @@ void ServiceWorkerDispatcher::OnRegistered(int32 thread_id,

// duplicate registration. So for now we mint a new object each

// time.

scoped_ptr<WebServiceWorkerImpl> worker(

- new WebServiceWorkerImpl(version_id, thread_safe_sender_));

+ new WebServiceWorkerImpl(handle_id, thread_safe_sender_));

callbacks->onSuccess(worker.release());

pending_callbacks_.Remove(request_id);

}