content/browser/service_worker/service_worker_url_request_job_unittest.cc - Issue 224733014: Introduce ServiceWorkerHandle for tracking WebServiceWorkerImpl reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_url_request_job_unittest.cc

Issue 224733014: Introduce ServiceWorkerHandle for tracking WebServiceWorkerImpl reference (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: sigh, rebased Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_unregister_job.cc ('k') | content/browser/service_worker/service_worker_version.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_url_request_job_unittest.cc

diff --git a/content/browser/service_worker/service_worker_url_request_job_unittest.cc b/content/browser/service_worker/service_worker_url_request_job_unittest.cc

index 2e9ab3863a04b682a77b5cc420d517b0249527c7..bf2585b923b18d1c47b1a052235e3d32755d960b 100644

--- a/content/browser/service_worker/service_worker_url_request_job_unittest.cc

+++ b/content/browser/service_worker/service_worker_url_request_job_unittest.cc

@@ -102,7 +102,7 @@ class ServiceWorkerURLRequestJobTest : public testing::Test {

scoped_ptr<ServiceWorkerProviderHost> provider_host(

new ServiceWorkerProviderHost(kProcessID, kProviderID,

- context_->AsWeakPtr()));

+ context_->AsWeakPtr(), NULL));

provider_host->AssociateVersion(version_.get());

url_request_job_factory_.SetProtocolHandler(

@@ -113,10 +113,8 @@ class ServiceWorkerURLRequestJobTest : public testing::Test {

}

virtual void TearDown() OVERRIDE {

- version_->Shutdown();

- version_ = 0;

- registration_->Shutdown();

- registration_ = 0;

+ version_ = NULL;

+ registration_ = NULL;

helper_.reset();

context_.reset();

}