content/browser/service_worker/service_worker_register_job.h - Issue 224733014: Introduce ServiceWorkerHandle for tracking WebServiceWorkerImpl reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_register_job.h

Issue 224733014: Introduce ServiceWorkerHandle for tracking WebServiceWorkerImpl reference (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: sigh, rebased Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_provider_host.cc ('k') | content/browser/service_worker/service_worker_register_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_register_job.h

diff --git a/content/browser/service_worker/service_worker_register_job.h b/content/browser/service_worker/service_worker_register_job.h

index 46aa9c89dbc05ae48ee815e6027cc9eb42154613..6e07c66f494cf3976d116868724a9d6eddce951f 100644

--- a/content/browser/service_worker/service_worker_register_job.h

+++ b/content/browser/service_worker/service_worker_register_job.h

@@ -34,6 +34,7 @@ class ServiceWorkerStorage;

class ServiceWorkerRegisterJob : public ServiceWorkerRegisterJobBase {

public:

typedef base::Callback<void(ServiceWorkerStatusCode status,

+ ServiceWorkerRegistration* registration,

ServiceWorkerVersion* version)>

RegistrationCallback;

@@ -66,6 +67,7 @@ class ServiceWorkerRegisterJob : public ServiceWorkerRegisterJobBase {

void Complete(ServiceWorkerStatusCode status);

void RunCallbacks(ServiceWorkerStatusCode status,

+ ServiceWorkerRegistration* registration,

ServiceWorkerVersion* version);

// The ServiceWorkerStorage object should always outlive this.