content/browser/service_worker/service_worker_context_core.cc - Issue 224733014: Introduce ServiceWorkerHandle for tracking WebServiceWorkerImpl reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_context_core.cc

Issue 224733014: Introduce ServiceWorkerHandle for tracking WebServiceWorkerImpl reference (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: sigh, rebased Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_context_core.h ('k') | content/browser/service_worker/service_worker_dispatcher_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_context_core.cc

diff --git a/content/browser/service_worker/service_worker_context_core.cc b/content/browser/service_worker/service_worker_context_core.cc

index b1c8ed7b5daa34d9220b9626e163b3760b648a6e..e6dc32f23807b94d0734c35b0110e0d0b4ebc4e0 100644

--- a/content/browser/service_worker/service_worker_context_core.cc

+++ b/content/browser/service_worker/service_worker_context_core.cc

@@ -93,6 +93,7 @@ void ServiceWorkerContextCore::UnregisterServiceWorker(

void ServiceWorkerContextCore::RegistrationComplete(

const ServiceWorkerContextCore::RegistrationCallback& callback,

ServiceWorkerStatusCode status,

+ ServiceWorkerRegistration* registration,

ServiceWorkerVersion* version) {

if (status != SERVICE_WORKER_OK) {

DCHECK(!version);

@@ -102,9 +103,10 @@ void ServiceWorkerContextCore::RegistrationComplete(

return;

}

- DCHECK(version->registration());

+ DCHECK(version);

+ DCHECK_EQ(version->registration_id(), registration->id());

callback.Run(status,

- version->registration()->id(),

+ registration->id(),

version->version_id());

}