Source/core/css/MediaValues.cpp - Issue 224733011: A sizes attribute parser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/MediaValues.cpp

Issue 224733011: A sizes attribute parser (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/MediaValues.cpp

diff --git a/Source/core/css/MediaValues.cpp b/Source/core/css/MediaValues.cpp

index 533562476a437a2e3061d531d862e209ba970495..5d8c9fdb067b51f3cd5ec0cb0d8cba84467ed287 100644

--- a/Source/core/css/MediaValues.cpp

+++ b/Source/core/css/MediaValues.cpp

@@ -193,10 +193,9 @@ PassRefPtr<MediaValues> MediaValues::create(LocalFrame* frame, RenderStyle* styl

return mediaValues;

}

-PassRefPtr<MediaValues> MediaValues::create(Document* document, MediaValuesMode mode)

+PassRefPtr<MediaValues> MediaValues::create(const Document& document, MediaValuesMode mode)

{

- ASSERT(document);

- Document* executingDocument = document->import() ? document->import()->master() : document;

+ const Document* executingDocument = document.import() ? document.import()->master() : &document;

eseidel 2014/04/08 06:02:14 const pointers to ref-counted objects rarely make

ASSERT(executingDocument->frame());

ASSERT(executingDocument->renderer());

ASSERT(executingDocument->renderer()->style());