Source/core/css/MediaQueryExp.cpp - Issue 224733011: A sizes attribute parser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/MediaQueryExp.cpp

Issue 224733011: A sizes attribute parser (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed rebase Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/MediaQueryExp.cpp

diff --git a/Source/core/css/MediaQueryExp.cpp b/Source/core/css/MediaQueryExp.cpp

index 1b8a8048e256bb05a2de1930c7577392a3fb6e0c..a7260d16cf7904170b34a02196238efa8c0803ba 100644

--- a/Source/core/css/MediaQueryExp.cpp

+++ b/Source/core/css/MediaQueryExp.cpp

@@ -215,6 +215,8 @@ PassOwnPtrWillBeRawPtr<MediaQueryExp> MediaQueryExp::createIfValid(const String&

{

ASSERT(!mediaFeature.isNull());

+ // FIXME - Creation of CSSValue here may not be thread safe.

+ // It should be replaced by a different way to pass the values to MediaQueryEvaluator.

RefPtrWillBeRawPtr<CSSValue> cssValue = nullptr;

bool isValid = false;

String lowerMediaFeature = attemptStaticStringCreation(mediaFeature.lower());

« no previous file with comments | « Source/core/css/MediaQueryEvaluatorTest.cpp ('k') | Source/core/css/MediaQuerySetTest.cpp » ('j') | no next file with comments »