Source/core/html/parser/HTMLDocumentParser.cpp - Issue 224733011: A sizes attribute parser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/parser/HTMLDocumentParser.cpp

Issue 224733011: A sizes attribute parser (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added invalid length layout test Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/parser/HTMLDocumentParser.cpp

diff --git a/Source/core/html/parser/HTMLDocumentParser.cpp b/Source/core/html/parser/HTMLDocumentParser.cpp

index 2e0b3c3d498b8816bd6189fcb84b6092946fee6e..29ca69e30bd57ce9e03f509465a1ed8d821dfad5 100644

--- a/Source/core/html/parser/HTMLDocumentParser.cpp

+++ b/Source/core/html/parser/HTMLDocumentParser.cpp

@@ -27,7 +27,7 @@

#include "core/html/parser/HTMLDocumentParser.h"

#include "HTMLNames.h"

-#include "core/css/MediaValues.h"

+#include "core/css/MediaValuesCached.h"

#include "core/dom/DocumentFragment.h"

#include "core/dom/Element.h"

#include "core/frame/LocalFrame.h"

@@ -540,7 +540,8 @@ Document* HTMLDocumentParser::contextForParsingSession()

static PassRefPtr<MediaValues> createMediaValues(Document* document)

{

- RefPtr<MediaValues> mediaValues = MediaValues::create(document, MediaValues::CachingMode);

+ ASSERT(document);

+ RefPtr<MediaValues> mediaValues = MediaValues::create(*document, MediaValues::CachingMode);

ASSERT(mediaValues->isSafeToSendToAnotherThread());

return mediaValues;

}