Source/core/css/CSSPrimitiveValue.cpp - Issue 224733011: A sizes attribute parser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSPrimitiveValue.cpp

Issue 224733011: A sizes attribute parser (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added invalid length layout test Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/CSSPrimitiveValue.cpp

diff --git a/Source/core/css/CSSPrimitiveValue.cpp b/Source/core/css/CSSPrimitiveValue.cpp

index 5126b62650dcd6e86b08fd183d2868e4fc3cf55e..a3770d783ccbb004996cc913dd122820e1b2b990 100644

--- a/Source/core/css/CSSPrimitiveValue.cpp

+++ b/Source/core/css/CSSPrimitiveValue.cpp

@@ -595,6 +595,8 @@ template<> double CSSPrimitiveValue::computeLength(const CSSToLengthConversionDa

double CSSPrimitiveValue::computeLengthDouble(const CSSToLengthConversionData& conversionData)

{

+ // The logic in this function is duplicated in MediaValues::computeLength for performance reasons.

eseidel 2014/04/14 22:55:32 Is MediaValues performance sensitive?

+ // Changes in logic here should be duplicated there as well.

if (m_primitiveUnitType == CSS_CALC)

return m_value.calc->computeLengthPx(conversionData);