Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: Source/core/css/MediaQueryExp.cpp

Issue 224733011: A sizes attribute parser (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed "final" syntax Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * CSS Media Query 2 * CSS Media Query
3 * 3 *
4 * Copyright (C) 2006 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>. 4 * Copyright (C) 2006 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>.
5 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 5 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
6 * Copyright (C) 2013 Apple Inc. All rights reserved. 6 * Copyright (C) 2013 Apple Inc. All rights reserved.
7 * 7 *
8 * Redistribution and use in source and binary forms, with or without 8 * Redistribution and use in source and binary forms, with or without
9 * modification, are permitted provided that the following conditions 9 * modification, are permitted provided that the following conditions
10 * are met: 10 * are met:
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 MediaQueryExp::MediaQueryExp(const String& mediaFeature, PassRefPtrWillBeRawPtr< CSSValue> value) 208 MediaQueryExp::MediaQueryExp(const String& mediaFeature, PassRefPtrWillBeRawPtr< CSSValue> value)
209 : m_mediaFeature(mediaFeature) 209 : m_mediaFeature(mediaFeature)
210 , m_value(value) 210 , m_value(value)
211 { 211 {
212 } 212 }
213 213
214 PassOwnPtrWillBeRawPtr<MediaQueryExp> MediaQueryExp::createIfValid(const String& mediaFeature, CSSParserValueList* valueList) 214 PassOwnPtrWillBeRawPtr<MediaQueryExp> MediaQueryExp::createIfValid(const String& mediaFeature, CSSParserValueList* valueList)
215 { 215 {
216 ASSERT(!mediaFeature.isNull()); 216 ASSERT(!mediaFeature.isNull());
217 217
218 // FIXME - Creation of CSSValue here may not be thread safe.
eseidel 2014/04/15 18:47:03 I guess we can't turn this on until we fix this?
219 // It should be replaced by a different way to pass the values to MediaQuery Evaluator.
218 RefPtrWillBeRawPtr<CSSValue> cssValue = nullptr; 220 RefPtrWillBeRawPtr<CSSValue> cssValue = nullptr;
219 bool isValid = false; 221 bool isValid = false;
220 String lowerMediaFeature = attemptStaticStringCreation(mediaFeature.lower()) ; 222 String lowerMediaFeature = attemptStaticStringCreation(mediaFeature.lower()) ;
221 223
222 // Create value for media query expression that must have 1 or more values. 224 // Create value for media query expression that must have 1 or more values.
223 if (valueList && valueList->size() > 0) { 225 if (valueList && valueList->size() > 0) {
224 if (valueList->size() == 1) { 226 if (valueList->size() == 1) {
225 CSSParserValue* value = valueList->current(); 227 CSSParserValue* value = valueList->current();
226 ASSERT(value); 228 ASSERT(value);
227 229
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
297 if (m_value) { 299 if (m_value) {
298 result.append(": "); 300 result.append(": ");
299 result.append(m_value->cssText()); 301 result.append(m_value->cssText());
300 } 302 }
301 result.append(")"); 303 result.append(")");
302 304
303 return result.toString(); 305 return result.toString();
304 } 306 }
305 307
306 } // namespace 308 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698