A sizes attribute parser

Source/core/css/MediaQueryEvaluatorTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/css/MediaQueryEvaluator.h"
 
 #include "core/css/MediaList.h"
-#include "core/css/MediaValues.h"
+#include "core/css/MediaValuesCached.h"
 #include "wtf/PassOwnPtr.h"
 #include "wtf/text/StringBuilder.h"
 
 #include <gtest/gtest.h>
 
 namespace WebCore {
 
 typedef struct {
     const char* input;
     const bool output;
 } TestCase;
 
 TEST(MediaQueryEvaluatorTest, Basic)
 {
     // The first string represents the input string.
     // The second string represents the output string, if present.
     // Otherwise, the output string is identical to the first string.
     TestCase screenTestCases[] = {
+        {"", 1},
+        {" ", 1},
         {"screen", 1},
         {"screen and (color)", 1},
         {"all and (min-width: 500px)", 1},
         {"not screen and (color)", 0},
         {"(min-width: 500px)", 1},
         {"(min-width: 501px)", 0},
         {"(max-width: 500px)", 1},
         {"(max-width: 499px)", 0},
         {"(width: 500px)", 1},
         {"(width: 501px)", 0},
@@ skipping 23 matching lines @@
         {"(hover: 1)", 1},
         {"(hover: 0)", 0},
         {0, 0} // Do not remove the terminator line.
     };
     TestCase printTestCases[] = {
         {"print and (min-resolution: 1dppx)", 1},
         {"print and (min-resolution: 118dpcm)", 0},
         {0, 0} // Do not remove the terminator line.
     };
 
-    RefPtr<MediaValues> mediaValues = MediaValues::create(MediaValues::CachingMode,
-        500, // Viewport Width
-        500, // Viewport height
-        500, // Device Width
-        500, // Device Height
-        2.0, // Device pixel ratio
-        24, // Color bits per component
-        0, // Monochrome bits per component
-        MediaValues::MousePointer, // Pointer device
-        16, // Default font size
-        true, // 3D enabled
-        false, // scan media type
-        true, // screen media type
-        false, // print media type
-        true // Strict mode
-        );
+    MediaValues::MediaValuesInitializer initializer;

[eseidel, 2014/04/14 22:55:32]

This is sooooo much easier to read /less error prone, thank you.

+    initializer.viewportWidth = 500;
+    initializer.viewportHeight = 500;
+    initializer.deviceWidth = 500;
+    initializer.deviceHeight = 500;
+    initializer.devicePixelRatio = 2.0;
+    initializer.colorBitsPerComponent = 24;
+    initializer.monochromeBitsPerComponent = 0;
+    initializer.pointer = MediaValues::MousePointer;
+    initializer.defaultFontSize = 16;
+    initializer.computedFontSize = 16;
+    initializer.hasXHeight = true;
+    initializer.xHeight = 16;
+    initializer.zeroWidth = 16;
+    initializer.threeDEnabled = true;
+    initializer.scanMediaType = false;
+    initializer.screenMediaType = true;
+    initializer.printMediaType = false;
+    initializer.strictMode = true;
+    RefPtr<MediaValues> mediaValues = MediaValuesCached::create(initializer);
 
     for (unsigned i = 0; screenTestCases[i].input; ++i) {
         RefPtrWillBeRawPtr<MediaQuerySet> querySet = MediaQuerySet::create(screenTestCases[i].input);
         MediaQueryEvaluator mediaQueryEvaluator("screen", *mediaValues);
         ASSERT_EQ(screenTestCases[i].output, mediaQueryEvaluator.eval(querySet.get()));
     }
     for (unsigned i = 0; printTestCases[i].input; ++i) {
         RefPtrWillBeRawPtr<MediaQuerySet> querySet = MediaQuerySet::create(printTestCases[i].input);
         MediaQueryEvaluator mediaQueryEvaluator("print", *mediaValues);
         ASSERT_EQ(printTestCases[i].output, mediaQueryEvaluator.eval(querySet.get()));
     }
 }
 
 } // namespace