Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/compiler/instruction-selector.cc

Issue 2247303007: [turbofan] fix deopt's input life span (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/instruction-selector.h" 5 #include "src/compiler/instruction-selector.h"
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "src/base/adapters.h" 9 #include "src/base/adapters.h"
10 #include "src/compiler/instruction-selector-impl.h" 10 #include "src/compiler/instruction-selector-impl.h"
(...skipping 351 matching lines...) Expand 10 before | Expand all | Expand 10 after
362 UNREACHABLE(); 362 UNREACHABLE();
363 break; 363 break;
364 default: 364 default:
365 if (rep == MachineRepresentation::kNone) { 365 if (rep == MachineRepresentation::kNone) {
366 return g->TempImmediate(FrameStateDescriptor::kImpossibleValue); 366 return g->TempImmediate(FrameStateDescriptor::kImpossibleValue);
367 } else { 367 } else {
368 switch (kind) { 368 switch (kind) {
369 case FrameStateInputKind::kStackSlot: 369 case FrameStateInputKind::kStackSlot:
370 return g->UseUniqueSlot(input); 370 return g->UseUniqueSlot(input);
371 case FrameStateInputKind::kAny: 371 case FrameStateInputKind::kAny:
372 return g->UseAny(input); 372 // Currently deopts "wrap" other operations, so the deopt's inputs
373 // are potentially needed untill the end of the deoptimising code.
374 return g->UseAnyAtEnd(input);
373 } 375 }
374 } 376 }
375 } 377 }
376 UNREACHABLE(); 378 UNREACHABLE();
377 return InstructionOperand(); 379 return InstructionOperand();
378 } 380 }
379 381
380 382
381 class StateObjectDeduplicator { 383 class StateObjectDeduplicator {
382 public: 384 public:
(...skipping 1681 matching lines...) Expand 10 before | Expand all | Expand 10 after
2064 return new (instruction_zone()) FrameStateDescriptor( 2066 return new (instruction_zone()) FrameStateDescriptor(
2065 instruction_zone(), state_info.type(), state_info.bailout_id(), 2067 instruction_zone(), state_info.type(), state_info.bailout_id(),
2066 state_info.state_combine(), parameters, locals, stack, 2068 state_info.state_combine(), parameters, locals, stack,
2067 state_info.shared_info(), outer_state); 2069 state_info.shared_info(), outer_state);
2068 } 2070 }
2069 2071
2070 2072
2071 } // namespace compiler 2073 } // namespace compiler
2072 } // namespace internal 2074 } // namespace internal
2073 } // namespace v8 2075 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/arm64/instruction-selector-arm64.cc ('k') | src/compiler/instruction-selector-impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698