Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2247303007: [turbofan] fix deopt's input life span (Closed)

Created:
4 years, 4 months ago by Rodolph Perfetta (ARM)
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] fix deopt's input life span Mark deopt's input alive till the end of the deopt instruction so they cannot be reused as output. BUG=v8:5158 Committed: https://crrev.com/e916dad343e0d0790edc529a3745b6f96f131799 Cr-Commit-Position: refs/heads/master@{#38875}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -26 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +1 line, -8 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 2 chunks +4 lines, -17 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Rodolph Perfetta
Hi, Sorry for the delay, but here is the proposed change to address issue 5158 ...
4 years, 4 months ago (2016-08-19 11:50:43 UTC) #2
Rodolph Perfetta
On 2016/08/19 11:50:43, Rodolph Perfetta wrote: > Hi, > > Sorry for the delay, but ...
4 years, 4 months ago (2016-08-19 11:52:00 UTC) #3
Benedikt Meurer
LGTM, thanks.
4 years, 4 months ago (2016-08-24 19:22:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2247303007/1
4 years, 4 months ago (2016-08-24 19:22:48 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 19:45:07 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 19:45:26 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e916dad343e0d0790edc529a3745b6f96f131799
Cr-Commit-Position: refs/heads/master@{#38875}

Powered by Google App Engine
This is Rietveld 408576698