Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2247303005: [heap] Use Page::FromAllocationAreaAddress when dealing with allocation info. (Closed)

Created:
4 years, 4 months ago by Hannes Payer (out of office)
Modified:
4 years, 4 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Use Page::FromAllocationAreaAddress when dealing with allocation info. BUG=chromium:630386 Committed: https://crrev.com/b82361cb63f83dc355c856f26189544ceee115ca Cr-Commit-Position: refs/heads/master@{#38706}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/heap/spaces.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Lippautz
lgtm
4 years, 4 months ago (2016-08-18 09:20:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2247303005/1
4 years, 4 months ago (2016-08-18 09:26:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 10:00:52 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 10:01:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b82361cb63f83dc355c856f26189544ceee115ca
Cr-Commit-Position: refs/heads/master@{#38706}

Powered by Google App Engine
This is Rietveld 408576698