Issue 224723023: Implements hanging property for text-indent from CSS3

Issue 224723023: Implements hanging property for text-indent from CSS3 (Closed)

Created:
6 years, 8 months ago by jaehun

Modified:
6 years, 8 months ago

Reviewers:
Julien - ping for review, darktears

CC:
blink-reviews, zoltan1, dsinclair, bemjb+rendering_chromium.org, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, pdr., rune+blink, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Implements hanging property for text-indent from CSS3 Spec: http://dev.w3.org/csswg/css-text/#text-indent-property ‘hanging’ means "Inverts which lines are affected". Merge from WebKit 1. https://bugs.webkit.org/show_bug.cgi?id=113680 2. https://bugs.webkit.org/show_bug.cgi?id=114663 BUG=360958 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171994

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update description #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+389 lines, -176 lines)			Patch
M	LayoutTests/StaleTestExpectations	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	LayoutTests/fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-expected.txt	View		7 chunks	+211 lines, -25 lines	0 comments	Download
M	LayoutTests/fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited-expected.txt	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/css3-text/css3-text-indent/getComputedStyle/script-tests/getComputedStyle-text-indent.js	View		1 chunk	+42 lines, -11 lines	0 comments	Download
M	LayoutTests/fast/css3-text/css3-text-indent/getComputedStyle/script-tests/getComputedStyle-text-indent-inherited.js	View		1 chunk	+4 lines, -0 lines	0 comments	Download
D	LayoutTests/fast/css3-text/css3-text-indent/text-indent-each-line.html	View		1 chunk	+0 lines, -37 lines	0 comments	Download
D	LayoutTests/fast/css3-text/css3-text-indent/text-indent-each-line-expected.html	View		1 chunk	+0 lines, -28 lines	0 comments	Download
A +	LayoutTests/fast/css3-text/css3-text-indent/text-indent-each-line-hanging.html	View		3 chunks	+24 lines, -2 lines	0 comments	Download
A +	LayoutTests/fast/css3-text/css3-text-indent/text-indent-each-line-hanging-expected.html	View		1 chunk	+22 lines, -17 lines	0 comments	Download
M	Source/core/css/CSSComputedStyleDeclaration.cpp	View	1	1 chunk	+9 lines, -2 lines	0 comments	Download
M	Source/core/css/CSSValueKeywords.in	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/css/parser/CSSPropertyParser.cpp	View	1	1 chunk	+26 lines, -32 lines	0 comments	Download
M	Source/core/css/resolver/StyleBuilderCustom.cpp	View	1	2 chunks	+19 lines, -14 lines	0 comments	Download
M	Source/core/rendering/line/BreakingContextInlineHeaders.h	View	1	1 chunk	+7 lines, -5 lines	0 comments	Download
M	Source/core/rendering/style/RenderStyle.h	View	1	3 chunks	+3 lines, -0 lines	0 comments	Download
M	Source/core/rendering/style/RenderStyleConstants.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/rendering/style/StyleRareInheritedData.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/rendering/style/StyleRareInheritedData.cpp	View	1	3 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Julien - ping for review

lgtm https://codereview.chromium.org/224723023/diff/1/LayoutTests/StaleTestExpectations File LayoutTests/StaleTestExpectations (left): https://codereview.chromium.org/224723023/diff/1/LayoutTests/StaleTestExpectations#oldcode105 LayoutTests/StaleTestExpectations:105: crbug.com/31488 [ Linux Mac ] fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent.html [ WontFix ...

6 years, 8 months ago (2014-04-18 18:48:02 UTC) #1

jaehun

https://codereview.chromium.org/224723023/diff/1/LayoutTests/StaleTestExpectations File LayoutTests/StaleTestExpectations (left): https://codereview.chromium.org/224723023/diff/1/LayoutTests/StaleTestExpectations#oldcode105 LayoutTests/StaleTestExpectations:105: crbug.com/31488 [ Linux Mac ] fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent.html [ WontFix ] ...

6 years, 8 months ago (2014-04-19 00:59:31 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ljaehun.lim@samsung.com/224723023/20001

6 years, 8 months ago (2014-04-19 04:23:57 UTC) #6

Message was sent while issue was closed.

Change committed as 171994

Expand Messages | Collapse Messages