Issue 224723021: Do not retain zombie CGL contexts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 224723021: Do not retain zombie CGL contexts (Closed)

Created:
6 years, 8 months ago by ccameron

Modified:
6 years, 8 months ago

Reviewers:
piman

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Do not retain zombie CGL contexts There are reports of failures when releasing the previous_context_ in ScopedCGLSetCurrentContext's destructor. The exact reason is unknown, but test applications have shown that it is possible for the current context to have a reference count of zero (in which case, the retain before setting the new context current does nothing, and the release after the new context is not current anymore may crash). If the previous context has a zero reference count, do not retain and release it, rather, set the context to NULL after the call completes. BUG=358473 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262510