Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1852)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/RenderCoordinates.java

Issue 224723019: [Android] Use latest page scale factor when computing content width (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use epsilon Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/RenderCoordinates.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/RenderCoordinates.java b/content/public/android/java/src/org/chromium/content/browser/RenderCoordinates.java
index 98961c01258195c2359396d16d96fe1ad3351009..0023dbdb991e631e57daf2d1f95ebc4746410f24 100644
--- a/content/public/android/java/src/org/chromium/content/browser/RenderCoordinates.java
+++ b/content/public/android/java/src/org/chromium/content/browser/RenderCoordinates.java
@@ -13,6 +13,11 @@ package org.chromium.content.browser;
* Unless stated otherwise, all coordinates are in CSS (document) coordinate space.
*/
public class RenderCoordinates {
+
+ // Used to accomodate finite precision when comparing scaled viewport and
+ // content widths in {@link #hasMobileViewport()}.
+ private static final float MOBILE_VIEWPORT_WIDTH_EPSILON = 0.005f;
+
// Scroll offset from the native in CSS.
private float mScrollXCss;
private float mScrollYCss;
@@ -274,8 +279,8 @@ public class RenderCoordinates {
* @return True if the page has a width=device-width or narrower viewport.
*/
public boolean hasMobileViewport() {
- float windowWidthDip = mPageScaleFactor * mLastFrameViewportWidthCss;
- return mContentWidthCss <= windowWidthDip;
+ final float windowWidthDip = mPageScaleFactor * mLastFrameViewportWidthCss;
+ return mContentWidthCss <= (windowWidthDip + MOBILE_VIEWPORT_WIDTH_EPSILON);
}
/**
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698